Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gulp-webserver with gulp-connect. Fixes issue #195. #221

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Replace gulp-webserver with gulp-connect. Fixes issue #195. #221

merged 1 commit into from
Feb 12, 2019

Conversation

djasnowski
Copy link

This adheres issue #195 and successfully replaces said NPM package (which had 2 bad vulns). When I ran npm audit, it had no more security concerns.

~/code/oss/morgan-stanley/desktopJS git:(master) npm audit

                       === npm audit security report ===

found 0 vulnerabilities
 in 50045 scanned packages

@djasnowski djasnowski requested a review from a team February 11, 2019 20:40
@djasnowski
Copy link
Author

@bingenito I hope this can fix it. A new PR with the commit (merged in one) and the covered by the DCO statement.

@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #221 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #221   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files          16       16           
  Lines        1479     1479           
  Branches      249      249           
=======================================
  Hits         1382     1382           
  Misses         97       97

Copy link
Member

@bingenito bingenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bingenito
Copy link
Member

@naknode Give me a day or so to work out future PR merge strategy on the repo now that we are dco. Whether it should be merge vs squash, etc. I had been doing squash and merge in the past.

@djasnowski
Copy link
Author

Same here, it was always simple but DCO is better. Thanks for your speedy input.

@bingenito bingenito merged commit 532b98f into morganstanley:master Feb 12, 2019
@bingenito
Copy link
Member

Fixes #195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants