Disable OpenFin window frame whenever enabled. #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
==========================================
- Coverage 93.44% 93.38% -0.07%
==========================================
Files 16 16
Lines 1480 1481 +1
Branches 249 249
==========================================
Hits 1383 1383
- Misses 97 98 +1
|
|
Coverage on this conditional path right now is very difficult because it is based on window global that is not currently provided via injection. |
psmulovics
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When OpenFin windows are ungrouped the frame is re-enabled. Attach to the enable event and disable the frame so it is immediately disabled and we can continue to use snap dock
Fixes #225