Fix/multitest parting revision #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyifan
requested changes
Jun 6, 2024
| "reason": data["reason"], | ||
| "strict": data["strict"], | ||
| } | ||
| for testcase in testcases_to_run: |
There was a problem hiding this comment.
why are we making this change, i think the original code is fine.
There was a problem hiding this comment.
ah i just want to remove extra if statements
yuxuan-ms
reviewed
Jun 18, 2024
testplan/common/report/base.py
Outdated
|
|
||
| def disassemble(self): | ||
| c = [] | ||
| for u in copy.copy(list(self._index.keys())): |
| @@ -392,6 +392,11 @@ def get_test_context(self): | |||
| ctx = [] | |||
| sorted_suites = self.cfg.test_sorter.sorted_testsuites(self.cfg.suites) | |||
|
|
|||
| if hasattr(self.cfg, "xfail_tests") and self.cfg.xfail_tests: | |||
There was a problem hiding this comment.
set self.cfg.xfail_tests default value to {} ?
There was a problem hiding this comment.
(i'd like to pretend that) self.cfg is immutable 😄
Pyifan
approved these changes
Jun 20, 2024
testplan/runnable/base.py
Outdated
| report.definition_name, | ||
| category=report.category, | ||
| ) | ||
| # here `report` must be an empty MultiTest report since |
There was a problem hiding this comment.
This part of comment needs a bit of refinement, to be more concise.
zhenyu-ms
added a commit
to zhenyu-ms/testplan
that referenced
this pull request
Jun 21, 2024
zhenyu-ms
added a commit
to zhenyu-ms/testplan
that referenced
this pull request
Jul 4, 2024
zhenyu-ms
added a commit
to zhenyu-ms/testplan
that referenced
this pull request
Jul 29, 2024
zhenyu-ms
added a commit
that referenced
this pull request
Jul 30, 2024
* impl round-robin-like parts merging * address review comments in #1097 * dedup * some refactor * add newsfrag; adjust comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug / Requirement Description
Clearly and concisely describe the problem.Solution description
use testcase-level round-robin scheduling for multitest parting (maybe more to go)
Checklist: