Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/multitest parting revision continued #1105

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Fix/multitest parting revision continued #1105

merged 5 commits into from
Jul 30, 2024

Conversation

zhenyu-ms
Copy link
Contributor

Bug / Requirement Description

TODO

Solution description

TODO

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@zhenyu-ms zhenyu-ms force-pushed the re-mt-parts-b branch 2 times, most recently from 80fd621 to 3aae02b Compare July 4, 2024 10:57
@zhenyu-ms zhenyu-ms marked this pull request as ready for review July 4, 2024 10:57
@zhenyu-ms zhenyu-ms requested a review from a team as a code owner July 4, 2024 10:57
Pyifan
Pyifan previously approved these changes Jul 29, 2024
View reviewed changes
yuxuan-ms
yuxuan-ms reviewed Jul 29, 2024
View reviewed changes
testplan/runnable/base.py
"""
res = []
i, j = 0, 0
while i < len(es):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for i in range(len(es))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well i tend to make i & j look more explicitly, so i have i = 0 and use while instead of for

testplan/runnable/base.py Outdated Show resolved Hide resolved
@zhenyu-ms zhenyu-ms merged commit 5b8390e into morganstanley:main Jul 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuxuan-ms yuxuan-ms yuxuan-ms left review comments

@Pyifan Pyifan Pyifan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhenyu-ms @Pyifan @yuxuan-ms