Added a new 'Run all' button to interactive toolbar on the web interface #981
Conversation
rnemes
changed the title
| @@ -72,6 +74,7 @@ class InteractiveReportComponent extends BaseReport { | |||
| navWidth: `${INTERACTIVE_COL_WIDTH}em`, | |||
| resetting: false, | |||
| reloading: false, | |||
| running: false, | |||
There was a problem hiding this comment.
So I looked at this new status and wonder two things:
- Can we do without it?
- If not, then we need to block certain actions when it is True. Right now I think we can trigger it twice without problem, send a reload during it, reset, etc... See for instance, how the reloadCode in InteractiveReport is handling it.
There was a problem hiding this comment.
Can we do without it?
We only need that for logging the state of the progress. However, we could use another variable eg.: runtime_status which could replace resetting, reloading, aborting as well, but in that case need to refactor the related functionalities.
If not, then we need to block certain actions when it is True. Right now I think we can trigger it twice without problem, send a reload during it, reset, etc... See for instance, how the reloadCode in InteractiveReport is handling it.
That makes sense. I will update the code.
| this.putUpdatedReportEntry(updatedReportEntry); | ||
| this.setState({ running: true }); | ||
| } | ||
| } |
There was a problem hiding this comment.
Once the fixes for the active filter issues are in, we probably need to see if it is working with a filter expression. If not, we will need to extend support, I do not think that piece of the API is handling the filtering.
There was a problem hiding this comment.
No, it doesn't handle filtering, it starts everything.
There was a problem hiding this comment.
As mentioned offline, this will be needed.
Co-authored-by: M6AI <[email protected]>
…into RunAllInteractive
| for test_uid in self.all_tests(): | ||
| self.run_test(test_uid) | ||
| if shallow_report: | ||
| self.logger.debug("Interactive mode: Run filtered tests") |
There was a problem hiding this comment.
Loglines are a welcome addition, but I do not see it for the others. Also I wonder if it is INFO level already or perhaps USER_INFO.
| </NavItem> | ||
| ); | ||
| } else { | ||
| if (props.filter) { |
There was a problem hiding this comment.
if (pops.filter) {
title="Run filtered tests"
} else {
title = "Run all tests"
}
return (
<NavItem key="runall-button">
<div className={css(styles.buttonsBar)}>
<FontAwesomeIcon
key="toolbar-runall"
className={css(styles.toolbarButton)}
icon={faPlay}
title={title}
onClick={props.runAllCbk}
/>
</div>
</NavItem>
)
Bug / Requirement Description
Clearly and concisely describe the problem.
Solution description
Describe your code changes in detail for reviewers.
Checklist: