Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify fromEvent() #17

Closed
TylorS opened this issue Dec 10, 2015 · 0 comments
Closed

Simplify fromEvent() #17

TylorS opened this issue Dec 10, 2015 · 0 comments
Assignees
@TylorS
Labels
type: feat
Milestone
Release v1.0.0

Comments

@TylorS
Copy link
Member

TylorS commented Dec 10, 2015

Overview

Currently fromEvent() accepts a single DOM node, but with minor changes it will accept a NodeList to avoid creating multiple Streams.

Motivation

Create as few Streams as possible to save memory and hopefully gain performance.
@TylorS TylorS self-assigned this Dec 10, 2015
TylorS added a commit that referenced this issue Dec 10, 2015
@TylorS
feat(): assume NodeList
503652d 
fromEvent() now assumes it is passed a NodeList and creates
a single stream from all of the elements of a NodeList.

Closes #17
TylorS added a commit that referenced this issue Dec 10, 2015
@TylorS
feat(): use new fromEvent() semantics
99be9d2 
Updates the use of fromEvent to match the new semantics

Closes #17
@TylorS TylorS mentioned this issue Dec 10, 2015
Merged
@TylorS TylorS added this to the Release v1.0.0 milestone Dec 11, 2015
Frikki referenced this issue Dec 11, 2015
@Frikki
Merge branch 'feat/issue-#17' into develop
5cfa0a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TylorS TylorS

Labels
type: feat
Projects
None yet
Milestone
Release v1.0.0
Development

No branches or pull requests
2 participants
@Frikki @TylorS