Feat/issue #17 #18
Merged
Feat/issue #17 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where is the test for this new feature? |
Adds a check for whether or not source is a NodeList
Add test to ensure fromEvent behaves as expected. Add test to ensure fromEvent throws when not given proper input.
|
Added tests in the latest commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
fromEvent()to accept a NodeList rather than a single DOM node.This allows creating only one Stream instead of multiple Streams that must be merged together.
Saving memory and hopefully increases performance by decreasing the number of steps and Streams being created.
Closes #17