Fix various missing test dependencies #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floatingatoll
changed the title
This was referenced Jul 22, 2021
floatingatoll
force-pushed
the
missing-mock
branch
4 times, most recently
from
ba65b83 to
faec02f
Compare
floatingatoll
force-pushed
the
missing-mock
branch
from
faec02f to
61d72d0
Compare
floatingatoll
requested review from
bkochendorfer and
duallain
and removed request for
gene1wood
This was referenced Jul 27, 2021
bkochendorfer
approved these changes
Jul 27, 2021
duallain
approved these changes
Jul 27, 2021
floatingatoll
force-pushed
the
missing-mock
branch
from
61d72d0 to
dcabb05
Compare
floatingatoll
force-pushed
the
missing-mock
branch
from
dcabb05 to
322021a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, reviewers.
I identified some missing dependencies for the setup.py "tests" phase, that need to be resolved in order for new CI to pass.
I've confirmed in #531 that new CI passes when these changes are incorporated.