Fix all flake8 errors found in current code #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floatingatoll
force-pushed
the
flake-fixes
branch
2 times, most recently
from
cd79a52 to
0221232
Compare
floatingatoll
force-pushed
the
flake-fixes
branch
from
0221232 to
27f57e2
Compare
floatingatoll
requested review from
bkochendorfer and
duallain
and removed request for
gene1wood
3 tasks
bkochendorfer
approved these changes
Jul 27, 2021
| def test_filtered_scan(benchmark): | ||
| #get_all_by_any() | ||
| # get_all_by_any() |
There was a problem hiding this comment.
huh, wonder why that's commented out
|
Yeah. I could guess, but it’s outside of scope for CI repair.
…On Tue, Jul 27, 2021 at 07:15 Brett Kochendorfer ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In python-modules/cis_identity_vault/integration_tests/test_all_users.py
<#530 (comment)>:
> def test_filtered_scan(benchmark):
- #get_all_by_any()
+ # get_all_by_any()
huh, wonder why that's commented out
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#530 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAWUDFHKGSCRCI3QZYZ3ODTZ25RTANCNFSM5AY7SAGA>
.
|
duallain
approved these changes
Jul 27, 2021
floatingatoll
force-pushed
the
flake-fixes
branch
from
27f57e2 to
3658d80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, reviewers.
While fixing CI I found a stack of flake8 errors (E###) that were preventing CI from running. I've separated them out for review purposes into this PR, so that they can be checked for sanity.
I have confirmed in #531 that the new CI passes when these are incorporated. It will not pass without these fixes.