This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Okay, lint doesn't like that we have translated strings now that are not used anymore... :) |
Codecov Report
@@ Coverage Diff @@
## master #2508 +/- ##
============================================
+ Coverage 83.05% 83.16% +0.11%
- Complexity 2814 2817 +3
============================================
Files 348 349 +1
Lines 11714 11815 +101
Branches 1719 1721 +2
============================================
+ Hits 9729 9826 +97
- Misses 1263 1265 +2
- Partials 722 724 +2
Continue to review full report at Codecov.
|
I disabled the lint checks for |
Amejia481
reviewed
Mar 25, 2019
Looks like I missed some tests that used those strings. I am going to update the PR. |
Amejia481
approved these changes
Mar 26, 2019
4 tasks
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are the new, reviewed strings from Michelle.