Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Update strings from review. #2508

Merged
merged 4 commits into from
Mar 26, 2019
Merged

Conversation

pocmo
Copy link
Contributor

@pocmo pocmo commented Mar 25, 2019

Those are the new, reviewed strings from Michelle.

@pocmo pocmo added the 🕵️‍♀️ needs review PRs that need to be reviewed label Mar 25, 2019
@pocmo pocmo requested a review from Amejia481 March 25, 2019 15:53
@pocmo pocmo requested a review from a team as a code owner March 25, 2019 15:53
@pocmo
Copy link
Contributor Author

pocmo commented Mar 25, 2019

Okay, lint doesn't like that we have translated strings now that are not used anymore... :)

@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #2508 into master will increase coverage by 0.11%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2508      +/-   ##
============================================
+ Coverage     83.05%   83.16%   +0.11%     
- Complexity     2814     2817       +3     
============================================
  Files           348      349       +1     
  Lines         11714    11815     +101     
  Branches       1719     1721       +2     
============================================
+ Hits           9729     9826      +97     
- Misses         1263     1265       +2     
- Partials        722      724       +2
Impacted Files Coverage Δ Complexity Δ
.../components/support/ktx/android/content/Context.kt 64.7% <0%> (-4.05%) 0 <0> (ø)
...la/components/feature/downloads/DownloadManager.kt 83.33% <100%> (+0.87%) 14 <1> (ø) ⬇️
.../feature/sitepermissions/SitePermissionsFeature.kt 89.7% <100%> (+0.03%) 80 <1> (ø) ⬇️
...ozilla/components/browser/errorpages/ErrorPages.kt 97.89% <0%> (ø) 3% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 585cf2b...f54560a. Read the comment docs.

@pocmo
Copy link
Contributor Author

pocmo commented Mar 25, 2019

I disabled the lint checks for MissingTranslation and ExtraTranslation. With our translation process it is possible that we will have missing translations (just not translated yet) or extra translations (the next import should remove them) temporarily.

@pocmo
Copy link
Contributor Author

pocmo commented Mar 25, 2019

Looks like I missed some tests that used those strings. I am going to update the PR.

@Amejia481 Amejia481 self-requested a review March 26, 2019 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants