This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Make loading page progress bar accessible to TalkBack. #2526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProgressBars can be made accessible to TalkBack by setting
android:accessibilityLiveRegion
.They will emit
TYPE_VIEW_SELECTED
events. TalkBack will format those events into percentageannouncements along with a pitch-change earcon. We are not using that feature here for
several reasons:
and since we only update the bar a handful of times, these events often never fire and
they don't give the user a true sense of the progress.
from being fired, so the user never gets a "complete" event.
"Progress bar, 25%". For a common feature like page load this is very chatty and unintuitive.
TalkBack will not play an earcon if an event has its own text.
For all those reasons, we are going another route here with a "loading" announcement
when the progress bar first appears along with scroll events that have the same
pitch-change earcon in TalkBack (although they are a bit louder). This gives a concise and
consistent feedback to the user that they can depend on.
Pull Request checklist