-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift Package Manager and M1 Support #9507
Conversation
977633e
to
6353feb
Compare
This pull request has conflicts when rebasing. Could you fix it @nbhasin2? |
This pull request has conflicts when rebasing. Could you fix it @nbhasin2? |
- General Cartfile cleanup
- Added Moz App Services with no glean test branch
Sample Firefox Beta upload: https://app.bitrise.io/build/47dd4ee5-66c1-4ba7-8de4-8da98ec387f6#?tab=log - Passed |
@nbhasin2 even though the tests are marked above as passed, that's wrong, they don't even run. There is a step in Bitrise at the very beginning failing and all the other steps, build and tests among them, are skipped. Do you want me to comment what to fix for Bitrise to run as in regular PRs or do you want to address that later? I don't want to add more noise here. |
I'm modifying bitrise.yml file in a different PR to try things out and give you the final solution once everything works. |
@isabelrios sounds good, yeah I figured you would be the best person to take a look at tests and modify them accordingly. Let me know if I can help in any way. |
I'm a bit stuck with the tests :/ . I'm trying to run them from command line to emulate the way the would run on Bitrise, but:
Just curious @nbhasin2 can you run the tests locally?
I saw that locally but got to fix it by building and then running the tests. On Bitrise even though I clear cache and build before running the tests, I can't fix that. I will keep working on this, but if something comes to your mind in the meantime about the issue that we may be facing, I appreciate your help. Thanks! |
… Storage test libs
@isabelrios I added the missing framework, let me know if that helps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
This pull request has conflicts when rebasing. Could you fix it @nbhasin2? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YESSSSS! 🚀
Linking Github issue: #9859 |
added:
moved:
updated:
removed:
todo:
Note:
Follow-up bug where A~S is not showing the a login screen: https://mozilla-hub.atlassian.net/browse/FXIOS-3695