feat(nimbus): add documentation links to new nimbus ui #11925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredlockhart
requested review from
yashikakhurana and
brennie
as code owners
|
oh I am really glad its all coming together, one thing I notices is the spacing between links are off, can we fix that? |
Because * We need to show the documentation links in the left sidebar * We want to show the new header with the title and timeline on every page This commit * Adds documentation links to the sidebar * Improves the styling of the sidebar * Moves the t new header to the base template so it appears on all pages fixes #11924
|
Oh yeah good catch @yashikakhurana okay I updated the html and screenshot 🙏 |
yashikakhurana
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
fixes #11924