feat(nimbus): add overview form to new nimbus ui #11926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredlockhart
requested review from
yashikakhurana and
brennie
as code owners
|
|
jaredlockhart
requested review from
RJAK11,
brennie and
yashikakhurana
and removed request for
brennie and
yashikakhurana
jaredlockhart
force-pushed
the
10841
branch
2 times, most recently
from
e98dc37 to
3232fcc
Compare
Becuase * We need to add the overview to the new Nimbus UI This commit * Adds the overview form * Adds documentation link add/remove functionality with HTMX fixes #10841
yashikakhurana
approved these changes
Dec 11, 2024
Comment on lines
+40
to
+51
| class RenderResponseMixin: | ||
| def form_valid(self, form): | ||
| super().form_valid(form) | ||
| return self.render_to_response(self.get_context_data(form=form)) | ||
|
|
||
|
|
||
| class RenderParentResponseMixin: | ||
| def form_valid(self, form): | ||
| super().form_valid(form) | ||
| form = super().form_class(instance=self.object) | ||
| return self.render_to_response(self.get_context_data(form=form)) | ||
|
|
There was a problem hiding this comment.
I Liked this mixin idea
Comment on lines
+104
to
+105
| <a target="_blank" | ||
| href="https://mana.mozilla.org/wiki/display/FIREFOX/Pref-Flip+and+Add-On+Experiments#PrefFlipandAddOnExperiments-Isthisstudypartnerrelated?riskPARTNER"> |
There was a problem hiding this comment.
for links like these, in my current work I am making the constant dict and will use it here, I can replace all that later, just wanted to let you know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Becuase
This commit
fixes #10841
