Merge pull request #18566 from calixteman/issue18561

Don't stop calculating field values when a Calculate callback throws

src/scripting_api/event.js

@@ -14,6 +14,7 @@
  */
 
 import {
+  serializeError,
   USERACTIVATION_CALLBACKID,
   USERACTIVATION_MAXTIME_VALIDITY,
 } from "./app_utils.js";
@@ -344,7 +345,15 @@ class EventDispatcher {
       event.value = null;
       const target = this._objects[targetId];
       let savedValue = target.obj._getValue();
-      this.runActions(source, target, event, "Calculate");
+      try {
+        this.runActions(source, target, event, "Calculate");
+      } catch (error) {
+        const fieldId = target.obj._id;
+        const serializedError = serializeError(error);
+        serializedError.value = `Error when calculating value for field "${fieldId}"\n${serializedError.value}`;
+        this._externalCall("send", [serializedError]);
+        continue;
+      }
       if (!event.rc) {
         continue;
       }

test/integration/scripting_spec.mjs

@@ -2461,4 +2461,32 @@ describe("Interaction", () => {
       );
     });
   });
+
+  describe("Calculate field value even if one callback throws", () => {
+    let pages;
+
+    beforeAll(async () => {
+      pages = await loadAndWait("issue18561.pdf", getSelector("24R"));
+    });
+
+    afterAll(async () => {
+      await closePages(pages);
+    });
+
+    it("must check that the product is computed although a callback threw", async () => {
+      await Promise.all(
+        pages.map(async ([browserName, page], i) => {
+          await waitForScripting(page);
+
+          const inputSelector = getSelector("24R");
+          await page.click(inputSelector);
+          await page.type(inputSelector, "123");
+          await page.click(getSelector("25R"));
+          await page.waitForFunction(
+            `${getQuerySelector("28R")}.value === "12300"`
+          );
+        })
+      );
+    });
+  });
 });

test/pdfs/.gitignore

@@ -660,3 +660,4 @@
 !issue18099_reduced.pdf
 !file_pdfjs_test.pdf
 !issue18536.pdf
+!issue18561.pdf