Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't stop calculating field values when a Calculate callback throws #18566

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Don't stop calculating field values when a Calculate callback throws #18566

merged 1 commit into from
Aug 6, 2024

Conversation

calixteman
Copy link
Contributor

It fixes #18561.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d5aeb994707e414/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/840e340dca6454a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d5aeb994707e414/output.txt

Total script time: 8.76 mins

  • Integration Tests: Passed

timvandermeij
timvandermeij reviewed Aug 5, 2024
View reviewed changes
test/integration/scripting_spec.mjs Outdated Show resolved Hide resolved
test/integration/scripting_spec.mjs Outdated Show resolved Hide resolved
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/840e340dca6454a/output.txt

Total script time: 18.24 mins

  • Integration Tests: Passed

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/942e74ecdb79d3f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/55b4d4bf3439cbf/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/942e74ecdb79d3f/output.txt

Total script time: 8.55 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/55b4d4bf3439cbf/output.txt

Total script time: 19.92 mins

  • Integration Tests: FAILED

@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8885b60f6b39299/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/8885b60f6b39299/output.txt

Total script time: 1.90 mins

Published

@timvandermeij timvandermeij merged commit 341a0b6 into mozilla:master Aug 6, 2024
8 checks passed
@timvandermeij
Copy link
Contributor

Thank you for improving this!

@YuvrajKaushal YuvrajKaushal mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
form-js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: PDF.js not Performing Calculations on Interactive PDF Forms
3 participants
@calixteman @moz-tools-bot @timvandermeij