-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduces UMD headers to the web/ folder. #7172
Conversation
TODOs:
|
33273f2
to
ccdffe2
Compare
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/3178a3857f06e63/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/3178a3857f06e63/output.txt Total script time: 1.43 mins Published |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/6b8ae65c8017b55/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/9440664c3ced265/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/9440664c3ced265/output.txt Total script time: 20.36 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/6b8ae65c8017b55/output.txt Total script time: 22.32 mins
|
root.pdfjsWebPDFFindController, root.pdfjsWebPDFFindBar, | ||
root.pdfjsWebMozPrintCallbackPolyfill, root.pdfjsWebPDFJS); | ||
} | ||
}(this, function (exports, uiUtils, firefoxCom, downloadManagerLib, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned on IRC, the fact that only some of these have Lib
at the end confused me initially.
So I'm wondering if we could append Lib
consistently on all of these, to reduce possible confusion here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Lib" suffix was added
In my testing this code seem to work exactly the same way as before, in both the viewer/addons. |
Awesome work! |
Fixes #6776