Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces UMD headers to the web/ folder. #7172

Merged
merged 3 commits into from
Apr 13, 2016

Conversation

yurydelendik
Copy link
Contributor

Fixes #6776

@yurydelendik
Copy link
Contributor Author

TODOs:

  • fix tests (unit and reference)
  • verify for the extensions
  • setup dependency between viewer and core module (atm they can be loaded in parallel)

@yurydelendik
Copy link
Contributor Author

Dependo diagram:

screen shot 2016-04-08 at 2 53 14 pm

@Snuffleupagus
Copy link
Collaborator

/botio-windows preview

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2016

From: Bot.io (Windows)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/3178a3857f06e63/output.txt

@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2016

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/6b8ae65c8017b55/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2016

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/9440664c3ced265/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2016

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/9440664c3ced265/output.txt

Total script time: 20.36 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Apr 9, 2016

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/6b8ae65c8017b55/output.txt

Total script time: 22.32 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

root.pdfjsWebPDFFindController, root.pdfjsWebPDFFindBar,
root.pdfjsWebMozPrintCallbackPolyfill, root.pdfjsWebPDFJS);
}
}(this, function (exports, uiUtils, firefoxCom, downloadManagerLib,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned on IRC, the fact that only some of these have Lib at the end confused me initially.
So I'm wondering if we could append Lib consistently on all of these, to reduce possible confusion here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Lib" suffix was added

@Snuffleupagus
Copy link
Collaborator

In my testing this code seem to work exactly the same way as before, in both the viewer/addons.
Hence I'm thinking that we can simply land this (pending an answer/fix to my question above), and then deal with any potential fallout in a follow-up (to avoid bit-rotting this PR).

@yurydelendik yurydelendik merged commit 6282ec2 into mozilla:master Apr 13, 2016
@timvandermeij
Copy link
Contributor

Awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants