[Regression] Eagerly fetch/parse the entire /Pages-tree in corrupt documents (issue 14303, PR 14311 follow-up) #14335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f9c3702cc3ab21e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d68cdda6296eae1/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f9c3702cc3ab21e/output.txt Total script time: 21.54 mins
Image differences available at: http://54.241.84.105:8877/f9c3702cc3ab21e/reftest-analyzer.html#web=eq.log |
…cuments (issue 14303, PR 14311 follow-up) *Please note:* This is similar to the method that existed prior to PR 3848, but the new method will *only* be used as a fallback when parsing of corrupt PDF documents. The implementation in PR 14311 unfortunately turned out to be *way* too simplistic, as evident by the recently added test-files in issue 14303, since it may *cause* infinite loops in `PDFDocument.checkLastPage` for some corrupt PDF documents.[1] To avoid this, the easiest solution that I could come up with was to fallback to eagerly parsing the *entire* /Pages-tree when the /Count-entry validation fails during document initialization. Fixes *at least* two of the issues listed in issue 14303, namely the `poppler-395-0.pdf...` and `GHOSTSCRIPT-698804-1.pdf...` documents. --- [1] The whole point of PR 14311 was obviously to *get rid of* infinte loops during document initialization, not to introduce any more of those.
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d68cdda6296eae1/output.txt Total script time: 42.24 mins
Image differences available at: http://54.193.163.58:8877/d68cdda6296eae1/reftest-analyzer.html#web=eq.log |
Snuffleupagus
force-pushed
the
Catalog-getAllPageDicts
branch
from
4993502 to
1fac637
Compare
timvandermeij
approved these changes
Dec 2, 2021
|
Nice work; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: This is similar to the method that existed prior to PR #3848, but the new method will only be used as a fallback when parsing of corrupt PDF documents.
The implementation in PR #14311 unfortunately turned out to be way too simplistic, as evident by the recently added test-files in issue #14303, since it may cause infinite loops in
PDFDocument.checkLastPagefor some corrupt PDF documents.[1]To avoid this, the easiest solution that I could come up with was to fallback to eagerly parsing the entire /Pages-tree when the /Count-entry validation fails during document initialization.
Fixes at least two of the issues listed in issue #14303, namely the
poppler-395-0.pdf...andGHOSTSCRIPT-698804-1.pdf...documents.[1] The whole point of PR #14311 was obviously to get rid of infinte loops during document initialization, not to introduce any more of those.