Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't traverse all pages to get a single page. #3848

Merged
merged 1 commit into from
Nov 14, 2013
Merged

Don't traverse all pages to get a single page. #3848

merged 1 commit into from
Nov 14, 2013

Conversation

brendandahl
Copy link
Contributor

Fixes #3811

@brendandahl
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/5f6ec59404e36cb/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/117af7a688721bf/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/117af7a688721bf/output.txt

Total script time: 23.91 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/5f6ec59404e36cb/output.txt

Total script time: 35.02 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/5f6ec59404e36cb/reftest-analyzer.xhtml#web=eq.log

@brendandahl
Copy link
Contributor Author

/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/2412bf7261ff534/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/2412bf7261ff534/output.txt

Total script time: 35.23 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/2412bf7261ff534/reftest-analyzer.xhtml#web=eq.log

@yurydelendik
Copy link
Contributor

http://www.unicode.org/L2/L2006/06334-reph-telugu-gurmukhi.pdf has error

[15:13:18.358] "Warning: Unhandled rejection: Error: There should be no more nodes to visit.
error@resource://pdf.js/build/pdf.worker.js:126
assert@resource://pdf.js/build/pdf.worker.js:144
Catalog_getPageDict/<@resource://pdf.js/build/pdf.worker.js:4615
runHandlers@resource://pdf.js/build/pdf.worker.js:795
"

yurydelendik
yurydelendik reviewed Nov 4, 2013
View reviewed changes
src/core/obj.js
this.pagePromises[pageIndex].resolve(page);
getPageDict: function Catalog_getPageDict(pageIndex, promise, nodesToVisit,
currentPageIndex) {
if (!promise) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can create closure here on promise, nodesToVisit, and currentPageIndex instead of passing them as parameters below -- might be easier to read the code

@Snuffleupagus
Copy link
Collaborator

@brendandahl It appears that you forgot to include the link to the test file.

@brendandahl
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/8220e2bde229aa2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/5e4f28c375b8944/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/8220e2bde229aa2/output.txt

Total script time: 24.20 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/5e4f28c375b8944/output.txt

Total script time: 36.61 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/5e4f28c375b8944/reftest-analyzer.xhtml#web=eq.log

brendandahl added a commit that referenced this pull request Nov 14, 2013
@brendandahl
Merge pull request #3848 from brendandahl/page-refs
7bdee40 
Don't traverse all pages to get a single page.
@brendandahl brendandahl merged commit 7bdee40 into mozilla:master Nov 14, 2013
@Snuffleupagus Snuffleupagus mentioned this pull request Nov 14, 2013
Closed
@Snuffleupagus Snuffleupagus mentioned this pull request Nov 23, 2013
Closed
brendandahl added a commit to brendandahl/pdf.js that referenced this pull request Nov 26, 2013
@brendandahl
Fix printing regression from mozilla#3848.
c9f2390
yurydelendik added a commit that referenced this pull request Nov 26, 2013
@yurydelendik
Merge pull request #3972 from brendandahl/print-reg
585a3d0 
Fix printing regression from #3848.
arrogantrobot pushed a commit to arrogantrobot/pdf.js that referenced this pull request Dec 24, 2013
@brendandahl
Fix printing regression from mozilla#3848.
5e04fc0
@Snuffleupagus Snuffleupagus mentioned this pull request Dec 25, 2013
Merged
@Snuffleupagus Snuffleupagus mentioned this pull request Jan 10, 2014
Closed
@Snuffleupagus Snuffleupagus mentioned this pull request Jan 14, 2015
Closed
@Snuffleupagus Snuffleupagus mentioned this pull request Feb 20, 2017
Closed
@Snuffleupagus Snuffleupagus mentioned this pull request Dec 2, 2021
Merged
@Snuffleupagus Snuffleupagus mentioned this pull request Dec 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disableAutoFetch=true not working with big pdf
4 participants
@brendandahl @pdfjsbot @yurydelendik @Snuffleupagus