Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill structuredClone with core-js (PR 13948 follow-up) #14392

Merged
merged 3 commits into from
Jan 27, 2022
Merged

Polyfill structuredClone with core-js (PR 13948 follow-up) #14392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fcd07f
Update Puppeteer to version `13.1.2`
Snuffleupagus Jan 18, 2022
7cc761a
Polyfill `structuredClone` with core-js (PR 13948 follow-up)
Snuffleupagus Jan 18, 2022
d476186
Temporarily disable the browser-tests in Google Chrome on the Windows…
Snuffleupagus Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"globals": {
"PDFJSDev": false,
"exports": false,
"structuredClone": false,
"SystemJS": false,
},

Expand Down
10 changes: 9 additions & 1 deletion gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,11 +555,19 @@ function createTestSource(testsName, { bot = false, xfaOnly = false } = {}) {
console.log("### Running " + testsName + " tests");

const PDF_TEST = process.env.PDF_TEST || "test_manifest.json";
let forceNoChrome = false;
const args = ["test.js"];
switch (testsName) {
case "browser":
if (!bot) {
args.push("--reftest");
} else {
const os = process.env.OS;
if (/windows/i.test(os)) {
// The browser-tests are too slow in Google Chrome on the Windows
// bot, causing a timeout, hence disabling them for now.
Snuffleupagus marked this conversation as resolved.
Show resolved Hide resolved
forceNoChrome = true;
}
}
if (xfaOnly) {
args.push("--xfaOnly");
Expand All @@ -582,7 +590,7 @@ function createTestSource(testsName, { bot = false, xfaOnly = false } = {}) {
if (bot) {
args.push("--strictVerify");
}
if (process.argv.includes("--noChrome")) {
if (process.argv.includes("--noChrome") || forceNoChrome) {
args.push("--noChrome");
}

Expand Down
90 changes: 55 additions & 35 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"autoprefixer": "^10.4.2",
"babel-loader": "^8.2.3",
"canvas": "^2.9.0",
"core-js": "^3.20.2",
"core-js": "^3.20.3",
"cross-env": "^7.0.3",
"dommatrix": "^0.0.24",
"es-module-shims": "^1.4.1",
Expand Down Expand Up @@ -41,7 +41,7 @@
"postcss": "^8.4.5",
"postcss-calc": "^8.2.2",
"prettier": "^2.5.1",
"puppeteer": "^13.0.1",
"puppeteer": "^13.1.2",
"rimraf": "^3.0.2",
"streamqueue": "^1.1.2",
"stylelint": "^14.2.0",
Expand Down
Loading