Polyfill structuredClone with core-js (PR 13948 follow-up)
#14392
Conversation
Snuffleupagus
force-pushed
the
polyfill-structuredClone
branch
from
19d86dc to
ed6f055
Compare
|
/botio unittest |
Snuffleupagus
force-pushed
the
polyfill-structuredClone
branch
from
ed6f055 to
1e91551
Compare
Snuffleupagus
force-pushed
the
polyfill-structuredClone
branch
2 times, most recently
from
5160659 to
414eaea
Compare
Snuffleupagus
force-pushed
the
polyfill-structuredClone
branch
from
414eaea to
bdcb8d3
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/22f4af683838d4e/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ba49486af21aa1b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ba49486af21aa1b/output.txt Total script time: 22.57 mins
Image differences available at: http://54.241.84.105:8877/ba49486af21aa1b/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/22f4af683838d4e/output.txt Total script time: 60.00 mins |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/58f997861b35adf/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/58f997861b35adf/output.txt Total script time: 60.00 mins |
Snuffleupagus
force-pushed
the
polyfill-structuredClone
branch
from
bdcb8d3 to
8e66d5b
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5272a7d9ed34645/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/bbc67c921f1c415/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/5272a7d9ed34645/output.txt Total script time: 22.91 mins
Image differences available at: http://54.241.84.105:8877/5272a7d9ed34645/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/bbc67c921f1c415/output.txt Total script time: 23.73 mins
Image differences available at: http://54.193.163.58:8877/bbc67c921f1c415/reftest-analyzer.html#web=eq.log |
Snuffleupagus
force-pushed
the
polyfill-structuredClone
branch
from
8e66d5b to
f533c61
Compare
Snuffleupagus
force-pushed
the
polyfill-structuredClone
branch
from
f533c61 to
fcbd839
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b75adb05bb71c54/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/32281eb30afd1d5/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/b75adb05bb71c54/output.txt Total script time: 23.66 mins
Image differences available at: http://54.241.84.105:8877/b75adb05bb71c54/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/32281eb30afd1d5/output.txt Total script time: 23.70 mins
Image differences available at: http://54.193.163.58:8877/32281eb30afd1d5/reftest-analyzer.html#web=eq.log |
Note in particular https://github.com/puppeteer/puppeteer/releases/tag/v13.1.0 which includes an update to Chromium 98, which adds support for `structuredClone` in the browser.
This allows us to remove the manually implemented `structuredClone` polyfill, thus reducing the maintenance burden for the `LoopbackPort` class; refer to https://github.com/zloirock/core-js#structuredclone *Please note:* While `structuredClone` support landed already in Firefox 94, Google Chrome only added it in version 98 (currently in Beta). However, given that the `LoopbackPort` will only be used together with *fake workers* in browsers this shouldn't be too much of a problem.[1] For Node.js environments, where *fake workers* are unfortunately necessary, using a `legacy/`-build is already required which thus guarantees that the `structuredClone` polyfill is available. Also, the patch updates core-js to the latest version since that one includes `structuredClone` improvements; please see https://github.com/zloirock/core-js/releases/tag/v3.20.3 --- [1] Given that we only support browsers with proper worker support, if *fake workers* are being used that essentially indicates a configuration problem/error.
… bot Either the latest Chromium update, the latest Puppeteer update, or a combination of them both are now causing the Windows bot to timeout during the browser-tests. To unblock both the updates and other improvements (i.e. the `structuredClone` polyfill), let's simply disable the problematic configuration for now since this a Mozilla project after all.
Snuffleupagus
force-pushed
the
polyfill-structuredClone
branch
from
fcbd839 to
d476186
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6fb540e5cf13d51/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8839b6e13915d40/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/6fb540e5cf13d51/output.txt Total script time: 22.98 mins
Image differences available at: http://54.241.84.105:8877/6fb540e5cf13d51/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/8839b6e13915d40/output.txt Total script time: 23.50 mins
Image differences available at: http://54.193.163.58:8877/8839b6e13915d40/reftest-analyzer.html#web=eq.log |
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9d8007d898e46bd/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f7bdd8313f0e0f6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9d8007d898e46bd/output.txt Total script time: 2.84 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f7bdd8313f0e0f6/output.txt Total script time: 5.46 mins
|
This allows us to remove the manually implemented
structuredClonepolyfill, thus reducing the maintenance burden for theLoopbackPortclass; refer to https://github.com/zloirock/core-js#structuredclonePlease note: While
structuredClonesupport landed already in Firefox 94, Google Chrome only added it in version 98 (currently in Beta). However, given that theLoopbackPortwill only be used together with fake workers in browsers this shouldn't be too much of a problem.[1]For Node.js environments, where fake workers are unfortunately necessary, using a
legacy/-build is already required which thus guarantees that thestructuredClonepolyfill is available.Also, the patch updates core-js to the latest version since that one includes
structuredCloneimprovements; please see https://github.com/zloirock/core-js/releases/tag/v3.20.3[1] Given that we only support browsers with proper worker support, if fake workers are being used that essentially indicates a configuration problem/error.