Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Puppeteer to version 13.1.1 #14471

Closed
wants to merge 2 commits into from

Conversation

Snuffleupagus
Copy link
Collaborator

Note in particular https://github.com/puppeteer/puppeteer/releases/tag/v13.1.0 which includes an update to Chromium 98, which adds support for structuredClone in the browser.

Note in particular https://github.com/puppeteer/puppeteer/releases/tag/v13.1.0 which includes an update to Chromium 98, which adds support for `structuredClone` in the browser.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2314c42a20a388f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/18e8211db619502/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/2314c42a20a388f/output.txt

Total script time: 22.52 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 13
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/2314c42a20a388f/reftest-analyzer.html#web=eq.log

… bot

Either the latest Chromium update, the latest Puppeteer update, or a combination of them both are now causing the Windows bot to timeout during the browser-tests.
To unblock both the updates and other improvements, let's simply disable the problematic configuration for now since this a Mozilla project after all.
@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/18e8211db619502/output.txt

Total script time: 60.00 mins

@timvandermeij
Copy link
Contributor

timvandermeij commented Jan 22, 2022

The Chrome on Windows failure here is really weird since it seems to work fine up until a certain point where it starts failing every test with Loading PDF document: Error: Setting up fake worker failed: "Cannot load script at: http://127.0.0.1:60301/build/generic/build/pdf.worker.js". It seems strange to me that it's using a fake worker in the first place?

@Snuffleupagus
Copy link
Collaborator Author

since it seems to work fine up until a certain point

I don't think it actually works all that well since the tests before that run extremely slow.
In any case, any objections to simply going ahead with disabling the affected configuration (since it's unrelated to Firefox) to avoid us becoming "stuck" with dependencies that we cannot update?

@timvandermeij
Copy link
Contributor

Not really. Let's land it as part of #14392 and close this one.

@Snuffleupagus Snuffleupagus deleted the update-puppeteer branch January 28, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants