Fix the transfer parameter, for structuredClone, in the LoopbackPort
#16175
Conversation
…Port` The way that we handle the `transfer` parameter is unfortunately wrong, ever since PR 14392 which introduced the code, given that the MDN article originally contained incorrect information; please see mdn/content#23164 By updating the `structuredClone` call such that it works correctly, we can enable more unit-tests in Node.js environments; please refer to https://developer.mozilla.org/en-US/docs/Web/API/structuredClone#parameters
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b4deb53097525b2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4187af9c61c9fcf/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/b4deb53097525b2/output.txt Total script time: 26.34 mins
Image differences available at: http://54.241.84.105:8877/b4deb53097525b2/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/4187af9c61c9fcf/output.txt Total script time: 31.79 mins
Image differences available at: http://54.193.163.58:8877/4187af9c61c9fcf/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
LGTM.
The other definition exists:
https://searchfox.org/mozilla-central/source/dom/webidl/Client.webidl#26
but I tested it in the console and it doesn't work...
The way that we handle the
transferparameter is unfortunately wrong, ever since PR #14392 which introduced the code, given that the MDN article originally contained incorrect information; please see mdn/content#23164By updating the
structuredClonecall such that it works correctly, we can enable more unit-tests in Node.js environments; please refer to https://developer.mozilla.org/en-US/docs/Web/API/structuredClone#parameters