Fix thumbnail rotation regression #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/6c0e0318e27af68/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/6c0e0318e27af68/output.txt Total script time: 0.21 mins Published
|
brendandahl
added a commit
that referenced
this pull request
Jan 2, 2014
…gression Fix thumbnail rotation regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a fairly recent regression that causes the thumbnails to not be rotated properly. The PRs responsible for the regression should be #3848, and to some extent #3978. The rotation issue might, for example, look like this:
In this patch, besides fixing the regression, I've also made sure that thumbnail rotations are handled the same way as page rotations. (Basically PR #3971, but for thumbnails.)
Note that the reason that I didn't add the thumbnail equivalent of this code: https://github.com/mozilla/pdf.js/blob/master/web/viewer.js#L871-L874, is that it isn't necessary and it also wouldn't help when
disableAutoFetch = true.