-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api-minor] Add support for URLs in the document outline #6822
Conversation
Note that it isn't too common for PDF files to include URLs in the outline, but as the referenced issue demonstrates, it does happen in practice. Given that this patch validates the URL, only absolute ones are allowed, it shouldn't really be more unsafe than normal LinkAnnotations. @timvandermeij Is this something that you'd be comfortable reviewing? |
Re: issue 5089. (Note that since there are other outline features that we currently don't support, e.g. bold/italic text and custom colours, I thus think we can keep the referenced issue open.)
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/54d50ed63f09754/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/54d50ed63f09754/output.txt Total script time: 0.86 mins Published |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/fa0509af12896a1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/fbc2446aff3db0b/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/fa0509af12896a1/output.txt Total script time: 21.36 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/fbc2446aff3db0b/output.txt Total script time: 21.45 mins
|
[api-minor] Add support for URLs in the document outline
Thank you for fixing this! |
Re: issue #5089.
(Note that since there are other outline features that we currently don't support, e.g. bold/italic text and custom colours, I thus think we can keep the referenced issue open.)