This repository has been archived by the owner on Dec 3, 2020. It is now read-only.
Instrument Firefox UI telemetry probes #157
Assignees
Milestone
Comments
biancadanforth
added a commit
that referenced
this issue
Oct 16, 2018
* Add `visit_supported_site` and `hide_toolbar_button` probes. * `hide_toolbar_button` required adding a new experimental API, `customizeUI`, which allows the extension to be notified when the Firefox CustomizeUI module detects the `onWidgetRemoved` event. This event fires any time a widget is removed from the chrome, including browserAction buttons. The widget is identified by a widgetId. * Update METRICS.md to move `uninstall` probe to Appendix, since it is handled by the Addons Manager's event telemetry already.
biancadanforth
added a commit
that referenced
this issue
Oct 23, 2018
* Add `visit_supported_site` and `hide_toolbar_button` probes. * `hide_toolbar_button` required adding a new experimental API, `customizeUI`, which allows the extension to be notified when the Firefox CustomizeUI module detects the `onWidgetRemoved` event. This event fires any time a widget is removed from the chrome, including browserAction buttons. The widget is identified by a widgetId. * Update METRICS.md to move `uninstall` probe to Appendix, since it is handled by the Addons Manager's event telemetry already.
biancadanforth
added a commit
that referenced
this issue
Oct 23, 2018
* Add `visit_supported_site` and `hide_toolbar_button` probes. * `hide_toolbar_button` required adding a new experimental API, `customizeUI`, which allows the extension to be notified when the Firefox CustomizeUI module detects the `onWidgetRemoved` event. This event fires any time a widget is removed from the chrome, including browserAction buttons. The widget is identified by a widgetId. * Update METRICS.md to move `uninstall` probe to Appendix, since it is handled by the Addons Manager's event telemetry already. * Create a new ./src/telemetry/content.js file to handle sending messages to the background telemetry script to record events from content scripts.
Osmose
added a commit
that referenced
this issue
Oct 23, 2018
Fix #157: Add Firefox UI telemetry probes
biancadanforth
added a commit
to biancadanforth/price-tracker
that referenced
this issue
Nov 2, 2018
Issue mozilla#157's patch removed this event from METRICS.md, but failed to remove it from the code. The uninstall event is recorded by the Addons Manager. It is not possible to record from a WE, as the extension is uninstalled before the event can be recorded.
biancadanforth
added a commit
to biancadanforth/price-tracker
that referenced
this issue
Nov 6, 2018
Issue mozilla#157's patch removed this event from METRICS.md, but failed to remove it from the code. The uninstall event is recorded by the Addons Manager. It is not possible to record from a WE, as the extension is uninstalled before the event can be recorded.
biancadanforth
added a commit
to biancadanforth/price-tracker
that referenced
this issue
Nov 6, 2018
Issue mozilla#157's patch removed this event from METRICS.md, but failed to remove it from the code. The uninstall event is recorded by the Addons Manager. It is not possible to record from a WE, as the extension is uninstalled before the event can be recorded.
biancadanforth
added a commit
to biancadanforth/price-tracker
that referenced
this issue
Nov 15, 2018
With CustomizableUI.jsm (via the experimental `browser.customizableUI` API added in mozilla#157), it is possible to detect when the browserAction toolbar button is and is not in the Overflow menu. Because the overflow menu width varies by OS (for example, it is 377px wide on my Mac 10.13 and 425px wide on a Linux 14.04), this patch will detect whether or not the toolbar button is in the Overflow menu and adjust the width accordingly. This fix has the added benefit of allowing us to constrain the non-Overflow menu popup width (which is hopefully the vast majority use case) to the UX spec of 320px where previously we had set it to a max-width of 400px to try to accomodate Overflow menu issues.
biancadanforth
added a commit
to biancadanforth/price-tracker
that referenced
this issue
Nov 16, 2018
With CustomizableUI.jsm (via the experimental `browser.customizableUI` API added in mozilla#157), it is possible to detect when the browserAction toolbar button is and is not in the Overflow menu. Because the overflow menu width varies by OS (for example, it is 377px wide on my Mac 10.13 and 425px wide on a Linux 14.04), this patch will detect whether or not the toolbar button is in the Overflow menu and adjust the width accordingly. This fix has the added benefit of allowing us to constrain the non-Overflow menu popup width (which is hopefully the vast majority use case) to the UX spec of 320px where previously we had set it to a max-width of 400px to try to accomodate Overflow menu issues.
biancadanforth
added a commit
to biancadanforth/price-tracker
that referenced
this issue
Nov 21, 2018
With CustomizableUI.jsm (via the experimental `browser.customizableUI` API added in mozilla#157), it is possible to detect when the browserAction toolbar button is and is not in the Overflow menu. Because the overflow menu width varies by OS (for example, it is 377px wide on my Mac 10.13 and 425px wide on a Linux 14.04), this patch will detect whether or not the toolbar button is in the Overflow menu and adjust the width accordingly. This fix has the added benefit of allowing us to constrain the non-Overflow menu popup width (which is hopefully the vast majority use case) to the UX spec of 320px where previously we had set it to a max-width of 400px to try to accomodate Overflow menu issues.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This issue covers instrumenting all probes related to Firefox's UI. The probes list was generated from METRICS.md (#134).
Events:
visit_supported_siteuninstallNote: Addon lifecycle events are already implemented via the Addon Manager's event telemetry with anextra_keysourceof'testpilot'.hide_toolbar_buttonThe text was updated successfully, but these errors were encountered: