This repository has been archived by the owner on Dec 3, 2020. It is now read-only.
Fix #157: Add Firefox UI telemetry probes #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Osmose
approved these changes
Oct 23, 2018
src/background/messages.js
Outdated
|
|
||
| // sendMessage/onMessage handlers | ||
|
|
||
| export const messageHandlers = new Map([ | ||
| ['extracted-product', handleExtractedProductData], | ||
| ['config', handleConfigMessage], | ||
| ['telemetry', async message => recordEvent( |
There was a problem hiding this comment.
We should probably define this handler elsewhere to match the pattern of the other handlers.
| CustomizableUI.removeListener(toolbarButton); | ||
| }; | ||
| }, | ||
| ).api(), |
* Add `visit_supported_site` and `hide_toolbar_button` probes. * `hide_toolbar_button` required adding a new experimental API, `customizeUI`, which allows the extension to be notified when the Firefox CustomizeUI module detects the `onWidgetRemoved` event. This event fires any time a widget is removed from the chrome, including browserAction buttons. The widget is identified by a widgetId. * Update METRICS.md to move `uninstall` probe to Appendix, since it is handled by the Addons Manager's event telemetry already. * Create a new ./src/telemetry/content.js file to handle sending messages to the background telemetry script to record events from content scripts.
Osmose
force-pushed
the
157-firefox-ui-probes
branch
from
e758504 to
ac7630c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
visit_supported_siteandhide_toolbar_buttonprobes.hide_toolbar_buttonrequired adding a new experimental API,customizeUI, which allows the extension to be notified when the Firefox CustomizeUI module detects theonWidgetRemovedevent. This event fires any time a widget is removed from the chrome, including browserAction buttons. The widget is identified by a widgetId.uninstallprobe to Appendix, since it is handled by the Addons Manager's event telemetry already.