The green badge is not displayed if opening a product's link in a new tab

[SoftVision-CarmenFat]

[Affected versions]:

• Firefox Release v63.0

[Affected Platforms]:

• All Windows
• All Linux
• All Mac

[Prerequisites]:

• Have a Firefox profile with the latest version of the "Price Wise" add-on (8.0.0) downloaded from (download link).

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Navigate to Walmart website.
3. Middle click on a product.
4. Wait for the products's page to load and click on the newly opened tab.
5. Observe the Price Wise badge.

[Expected result]:

• The green badge is displayed.

[Actual result]:

• The initial state badge is displayed.

[Notes]:

• This issue is reproducible only with the Walmart website.
• This is also reproducible when opening the link from the context menu.
• Here is a screen recording of the issue:

[Osmose]

Based on my testing, this appears to be caused by the same thing as #192/#242. New iframes are clearing the browser action icon once you view the page (notice the flickering badge), and since the pages were opened in new tabs and some time is passing before you switch to them, the 5- and 10-second workarounds for resetting the badge aren't taking effect.

[chuckharmston]

@Osmose Not sure if the add-on is structured in a way that you can do this, but I've worked around similar issues by ensuring that the browserAction's state is only changed as the result of requests where details.frameId === 0.

[Osmose]

@Osmose Not sure if the add-on is structured in a way that you can do this, but I've worked around similar issues by ensuring that the browserAction's state is only changed as the result of requests where details.frameId === 0.

The annoying thing about this bug is that it isn't our code that's resetting the browser action. It's the in-product extension code mistakenly identifying an iframe load as a top level page load and resetting it. The relevant bug is bug 1493470, but it landed in 64, so we have a single release cycle of dealing with this before it stops being a problem.

[Osmose]

@SoftVision-CarmenFat Can you confirm whether you see the issue with this build of the add-on? https://usercontent.irccloud-cdn.com/file/LCrGGoJF/price_wise-8.0.1-signed.xpi

[SoftVision-CarmenFat]

• Tested this with the latest Price Wise build (v.8.0.1) and the issue is no longer reproducible.
• The products that are opened in new tabs are now compatible with Price Wise and the toolbar button correctly displays the green badge.
• Tested on Windows 10 x64, Mac 10.13 and Arch Linux.

[Osmose]

The fix in question has not been released, 8.0.1 is just a test build I made. We still need to fix this.

[SoftVision-CarmenFat]

I have verified this issue using the latest Price Wise version (15.0.0) from Test Pilot platform and the issue is no longer reproducible. Tested on Windows 10, Mac 10.13 and Arch Linux 4.16.6 x64.