Skip to content
This repository has been archived by the owner on Dec 3, 2020. It is now read-only.

"Add This Product" button becomes active only after a few secconds on slow connections. #242

Closed
muccimoz opened this issue Nov 1, 2018 · 5 comments
Milestone

Comments

@muccimoz
Copy link
Collaborator

muccimoz commented Nov 1, 2018

I have verified this issue using the latest version of the Price Wise (8.0.0-signed) version and the issue is still reproducible on https://www.walmart.com/, using a slow Internet connection. The "Add This Product" button is briefly active after the page is fully loaded and after that is no longer active.

However, on https://www.homedepot.com/, after the page is fully loaded, the "Add This Product" button becomes active only after a few secconds.

In order to test this I have simulated a slow Internet connection using the "Network Link Conditioner" app.,on Mac, and also with the functionality from RDM mode.
Attached is a screen recording of the issue:

slowinternet

Originally posted by @Softvision-RemusDranca in #192 (comment)

@Osmose
Copy link
Contributor

Osmose commented Nov 3, 2018

@Softvision-RemusDranca I've made a version of the add-on with the original workaround we had: https://usercontent.irccloud-cdn.com/file/LCrGGoJF/price_wise-8.0.1-signed.xpi

Using that add-on on release, I can't replicate the bug at all, on slow or fast connections. Can you confirm whether you can replicate the issue with it?

@Softvision-RemusDranca
Copy link

I have retested this issue with a slow connection using the provided Price Wise (8.0.1-signed) version, and the issue is no longer reproducible.
However, I have observed that the green badge flickers while the page is loading. Is more visible on slow connections, but this can also be observed on good connection. Should I log a new issue for this behavior, for tracking purpose?
Tested on Windows 10 x64, Mac 10.13 and Ubuntu 18.04 x64.
Here is a screen recording:
flicker

@muccimoz
Copy link
Collaborator Author

muccimoz commented Nov 5, 2018

I'm going to close this issue as it has been verified that it is no longer happening. Please file a new issue for the flickering behavior.

@muccimoz muccimoz closed this as completed Nov 5, 2018
@muccimoz muccimoz added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Nov 5, 2018
@Osmose Osmose reopened this Nov 5, 2018
@Osmose
Copy link
Contributor

Osmose commented Nov 5, 2018

Reopening, as the 8.0.1 version was a one-off build, and this fix has not landed yet.

@muccimoz muccimoz removed the [QA]:Verified fixed Label for QA to mark verified fixed issues label Nov 5, 2018
@Osmose
Copy link
Contributor

Osmose commented Nov 5, 2018

However, I have observed that the green badge flickers while the page is loading. Is more visible on slow connections, but this can also be observed on good connection. Should I log a new issue for this behavior, for tracking purpose?

We'd probably mark it as WONTFIX as it's an unavoidable side effect of bug 1493470. Once 64 hits release it won't happen anymore, but until then there's not much we can do besides this workaround and its flickering.

If filing and WONTFIXing it helps your tracking though, that's cool.

@Osmose Osmose closed this as completed Nov 5, 2018
@Osmose Osmose reopened this Nov 5, 2018
Osmose pushed a commit to Osmose/price-wise that referenced this issue Nov 5, 2018
@Osmose Osmose closed this as completed in 578eb0c Nov 7, 2018
Osmose added a commit that referenced this issue Nov 7, 2018
Fix #237, fix #242: Re-add toolbar icon reset workaround.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants