Workflow updates #171

kwizart · 2023-07-21T12:10:46Z

This is a workflow update needed to fix the failing distros and pre-commit checks.

Description

Remove debian9
Add debian12
Update ansible-lint (and others) in pre-commit to fix

Related Issue

NA

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

I have read the CONTRIBUTING document.
I have run the pre-merge tests locally and they pass.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.

Some error where discovered by fixing this ansible-lint:

ignore-errors: Use failed_when and specify error conditions instead of using ignore_errors.
tasks/configure_root_access.yml:2 Task/Handler: configure_root_access | updating root passwords

warning[outdated-tag]: Replaced outdated tag '503' with 'no-handler', replace it to avoid future errors (warning)
tasks/mysql_databases.yml:15

no-changed-when: Commands should not change things if nothing needs doing.
tasks/setup_cluster.yml:124 Task/Handler: setup_cluster | custer bootstrap - killing lingering mysql processes to ensure mysql is stopped

no-changed-when: Commands should not change things if nothing needs doing.
tasks/setup_cluster.yml:141 Task/Handler: setup_cluster | cluster bootstrap - bootstrapping first node

Read documentation for instructions on how to ignore specific rule violations.

kwizart · 2023-07-24T14:02:35Z

To note: I'm not sure why the debian 12 job is failing, maybe I haven't done anything to tweak the debian base image as appropriate as I'm using debian:12 whereas previous was using mrlesmithjr/debian:11 ...

eRadical · 2023-07-24T14:09:36Z

Yes @kwizart - we need another image in https://github.com/mrlesmithjr/dockerfiles/tree/main

see details at https://github.com/mrlesmithjr/dockerfiles/blob/main/debian/11/Dockerfile
I may have some time this afternoon to look into this

kwizart · 2023-07-24T14:27:25Z

OK, so I have forced-push to use mrlesmithjr/debian:12 (and defer the fix for a later PR)

eRadical · 2023-07-24T14:32:07Z

Now we will wait for @mrlesmithjr to merge debian 12 in dockerfiles and then will see this complete also.

eRadical · 2023-07-25T05:21:29Z

Puzzled about the last Debian 12 fail 🤕

eRadical · 2023-07-25T08:35:39Z

I think I found the issue.
It may be because of https://peps.python.org/pep-0668/ - I'll try a fix in debian:12 image.

eRadical · 2023-07-25T14:49:08Z

Latest error for Debian 12 is:

  TASK [ansible-mariadb-galera-cluster : debian | installing pre-reqs] ***********
  fatal: [node2]: FAILED! => {"changed": false, "msg": "No package matching 'python-pymysql' is available"}
  fatal: [node1]: FAILED! => {"changed": false, "msg": "No package matching 'python-pymysql' is available"}

If @kwizart doesn't have time I'll try to have a go at it when I'm home!

eRadical · 2023-07-26T06:46:16Z

For Debian 12 we need: python3-pymysql

eRadical · 2023-07-26T06:58:22Z

@kwizart - you just need to copy vars/debian-11.yml as vars/debian-12.yml (because of the first found).

eRadical · 2023-07-26T08:02:29Z

Bummer... we're in "OS contribution rabbit whole" :)

MariaDB does not build yet for Debian 12.
We could use repo for Debian 11 until they do so, but my Debian/Ubuntu experience ends here... so I must summon @elcomtik || @mrlesmithjr ! :|

eRadical · 2023-07-26T08:05:44Z

...or we could wait a few days - https://jira.mariadb.org/projects/MDEV/versions/29013 - MariaDB 10.6.15 will be released on 2023-07-27 and most probably will also contain a build for Debian 12 (see https://jira.mariadb.org/browse/MDEV-31476).

elcomtik · 2023-07-26T08:21:19Z

I would wait until they build it for Debian 12, doing otherwise may only bring other issues.

eRadical · 2023-08-20T16:45:35Z

Bummer, the MDEV-31476 was updated: we will not have MariaDB 10.6.x for Debian 12, only MariaDB 10.11.y.

@elcomtik && @mrlesmithjr - do we upgrade to MariaDB 10.11 for all or only for Debian 12? What are your thoughts?

elcomtik · 2023-08-21T08:06:11Z

I would upgrade mariadb version for all distros. Role should be updated continuosly and we just need to inform users pin mariadb version in their deployments.

kwizart · 2023-08-21T13:25:43Z

I've tried to set it in the molecule config for Debian 12 to avoid to bump the default (either defaults/main.yaml or vars/debian-12) as it's probably better for end-users to select the appropriate mariadb_version themselves.
(so debian-12 users will break if they don't set a higher mariadb_version).

Then it should be possible to deprecate having a default mariadb_version set at all. So it will fully defer this choice/responsibility to users.

An alternative/possible solution would be to only bump vars/debian-12.yml to a sane default.
But this move the problem, as picking 10.11 over 11.1 is hidden to users.

Bumps [cryptography](https://github.com/pyca/cryptography) from 39.0.1 to 41.0.0. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@39.0.1...41.0.0) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Centos Stream 8 is another distribution

This fixes the following error from ansible-lint: ... File "/home/runner/.cache/pre-commit/repory1hpslb/py_env-python3.9/lib/python3.9/site-packages/ansible_compat/prerun.py", line 13, in get_cache_dir basename = project_dir.resolve().name.encode(encoding="utf-8") AttributeError: 'str' object has no attribute 'resolve' This is because ansible-lint doesn't support the new api from ansible-compat v4 see also ansible/ansible-compat#258 (comment)

To be fixed at a later point

eRadical · 2023-08-26T13:32:45Z

I must say I merged even though I don't agree w/ disabling centos8.
I'll reenable it later.

kwizart · 2023-08-27T13:20:31Z

I must say I merged even though I don't agree w/ disabling centos8. I'll reenable it later.

Sorry, but this was never raised. Why do you disagree ? I'm a fedora/EPEL contributor so I'm very interested in centos eco-system itslef. But centos8 is just EOL distro. specially over rocky8 and later. As I said centos stream is a a different thing tought.

kwizart · 2023-08-27T13:34:24Z

I would upgrade mariadb version for all distros. Role should be updated continuosly and we just need to inform users pin mariadb version in their deployments.

I think bumping should be done at some point, but then there is a need to have a safe guard.
That way, users will not suddenly upgrade their mariadb version unexpectedly while upgrading the role.

I would go with: if early in the role the already installed mariadb version doesn't "start with" the major version set in the ansible variable and ansible_allow_upgrade_major_mariadb is False, then the role should exit early asking to set the mariadb_version.

That should prevent any surprise... (I might fill a dedicated ticket/PR for this issue)

With that said, I would probably drop the dedicated mariadb_version set in debian-12. I feel uncomfortable with this on a second tough (as I create another place where the version is set instead in the role of global location).

Btw, thanks for having merged this PR!

eRadical · 2023-08-28T07:11:31Z

I have upgraded all CentOS 8 server to CentOS 8 Stream and I haven't felt any difference - of course this is anecdotal evidence but it's the simplest path for those that were and are still on CentOS 8.

The image was already moved by @mrlesmithjr to centos8stream which basically ensures continuous compatibility for those that upgraded from CentOS 8 to CentOS Stream.

Also we should introduce CentOS 9 Stream.

kwizart · 2023-08-28T08:39:11Z

So if there is a dedicated centos8stream and centos8stream tests, I'm fine. But having centos8 is miss-leading.

eRadical · 2023-08-28T09:23:26Z

Not necessarily since everyone knows centos8 was changed into centos8stream.

kwizart · 2023-08-28T10:03:38Z

Unfortunately no: centos8 (Linux, aka EOL) usage on mirrors are still dramatically high.
So using the same name as previous Centos Linux is miss-leading and using centos8stream will highlight different pace compared to rocky8.

Properly naming things is not is not a side thing.

eRadical · 2023-08-28T10:26:12Z

I agree to just disagree on this :)

* Bump cryptography from 39.0.1 to 41.0.0 * Disable debian9 && centos8 superseeded by rocky8, Centos Stream 8 is another distribution * Bump pre-commit version to current * [molecule] Add debian12 scenario * Add debian-12 vars * [ansible-lint] remove outdated tag * [ansible-lint] Add .ansible-lint-ignore To be fixed at a later point * Add default mariadb version for debian-12 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

kwizart mentioned this pull request Jul 21, 2023

Python2/3 galeranotify support #168

Merged

9 tasks

eRadical requested review from mrlesmithjr and elcomtik July 24, 2023 13:02

mrlesmithjr approved these changes Jul 24, 2023

View reviewed changes

kwizart force-pushed the workflow-updates branch from 256cad4 to 0d5fa40 Compare July 24, 2023 14:26

eRadical mentioned this pull request Jul 24, 2023

Add Debian 12 mrlesmithjr/dockerfiles#50

Merged

9 tasks

kwizart mentioned this pull request Jul 24, 2023

Add debian:12 mrlesmithjr/dockerfiles#51

Closed

9 tasks

mrlesmithjr approved these changes Jul 24, 2023

View reviewed changes

eRadical mentioned this pull request Jul 25, 2023

remove EXTERNALLY-MANAGED file to disable PEP 668 mrlesmithjr/dockerfiles#52

Merged

9 tasks

dependabot bot and others added 6 commits August 21, 2023 17:01

Disable debian9 && centos8 superseeded by rocky8

ec5db03

Centos Stream 8 is another distribution

[molecule] Add debian12 scenario

c99f151

Add debian-12 vars

ad7c216

[ansible-lint] remove outdated tag

448ca92

kwizart added 2 commits August 21, 2023 17:01

[ansible-lint] Add .ansible-lint-ignore

333b6fa

To be fixed at a later point

Add default mariadb version for debian-12

d49f3b6

kwizart force-pushed the workflow-updates branch from b3669f2 to d49f3b6 Compare August 21, 2023 15:02

eRadical merged commit 610551c into mrlesmithjr:master Aug 26, 2023
9 checks passed

kwizart mentioned this pull request Aug 30, 2023

Mariadb version bump and check #174

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Workflow updates #171

Workflow updates #171

kwizart commented Jul 21, 2023 •

edited

Loading

kwizart commented Jul 24, 2023

eRadical commented Jul 24, 2023 •

edited

Loading

kwizart commented Jul 24, 2023

eRadical commented Jul 24, 2023

eRadical commented Jul 25, 2023

eRadical commented Jul 25, 2023

eRadical commented Jul 25, 2023

eRadical commented Jul 26, 2023

eRadical commented Jul 26, 2023

eRadical commented Jul 26, 2023 •

edited

Loading

eRadical commented Jul 26, 2023

elcomtik commented Jul 26, 2023

eRadical commented Aug 20, 2023

elcomtik commented Aug 21, 2023

kwizart commented Aug 21, 2023 •

edited

Loading

eRadical commented Aug 26, 2023

kwizart commented Aug 27, 2023

kwizart commented Aug 27, 2023

eRadical commented Aug 28, 2023

kwizart commented Aug 28, 2023

eRadical commented Aug 28, 2023

kwizart commented Aug 28, 2023

eRadical commented Aug 28, 2023

Workflow updates #171

Workflow updates #171

Conversation

kwizart commented Jul 21, 2023 • edited Loading

Description

Related Issue

Types of changes

Checklist:

kwizart commented Jul 24, 2023

eRadical commented Jul 24, 2023 • edited Loading

kwizart commented Jul 24, 2023

eRadical commented Jul 24, 2023

eRadical commented Jul 25, 2023

eRadical commented Jul 25, 2023

eRadical commented Jul 25, 2023

eRadical commented Jul 26, 2023

eRadical commented Jul 26, 2023

eRadical commented Jul 26, 2023 • edited Loading

eRadical commented Jul 26, 2023

elcomtik commented Jul 26, 2023

eRadical commented Aug 20, 2023

elcomtik commented Aug 21, 2023

kwizart commented Aug 21, 2023 • edited Loading

eRadical commented Aug 26, 2023

kwizart commented Aug 27, 2023

kwizart commented Aug 27, 2023

eRadical commented Aug 28, 2023

kwizart commented Aug 28, 2023

eRadical commented Aug 28, 2023

kwizart commented Aug 28, 2023

eRadical commented Aug 28, 2023

kwizart commented Jul 21, 2023 •

edited

Loading

eRadical commented Jul 24, 2023 •

edited

Loading

eRadical commented Jul 26, 2023 •

edited

Loading

kwizart commented Aug 21, 2023 •

edited

Loading