Mariadb version bump and check #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwizart
force-pushed
the
mariadb_version_bump
branch
2 times, most recently
from
8eebaf0
to
de85fe8
Compare
|
@kwizart why did you also changed |
kwizart
force-pushed
the
mariadb_version_bump
branch
from
de85fe8
to
7947932
Compare
whoops, wrong commit leftover from previous branch... |
kwizart
force-pushed
the
mariadb_version_bump
branch
from
7947932
to
c128390
Compare
|
After few quickfixes to pass Molecules tests, the ubuntu1804 are unlikely related to the PR. Only point is probably to reword the assert fails message as If I'm keeping the previous debug task, then the message can be simplified... |
|
LGTM @elcomtik || @mrlesmithjr - any thoughts? |
|
Looks very promising, let's merge it! |
cmayer89
pushed a commit
to cmayer89/ansible-mariadb-galera-cluster
that referenced
this pull request
Sep 7, 2023
* Bump the default mariadb_version to 10.11 * Drop hardcoded version in debian-12 * Set default mariadb_upgrade: false * Implement a mariadb_version check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bump the default mariadb_version and implement a preliminary version check.
Description
But user should note that using this version is arbitrary, they should carefully mind the right version for their use.
Related Issue
Issue raised on PR:
#171 (comment)
Types of changes
Checklist: