-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add today and clear buttons for inline pickers #782
Add today and clear buttons for inline pickers #782
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #782 +/- ##
==========================================
Coverage ? 91.07%
==========================================
Files ? 41
Lines ? 1434
Branches ? 173
==========================================
Hits ? 1306
Misses ? 93
Partials ? 35
Continue to review full report at Codecov.
|
I am sorry. But we are not going to support dialog actions for inline pickers. |
@dmtrKovalenko Why not? This is rather disappointing, it is important functionality and it should work with inline pickers too. Documentation doesn't even mention that 'showTodayButton' works only with standard pickers. |
@dmtrKovalenko Thanks for this awsome pickers. But I have the same question. What are the reasons to not support this functionality? Having ability to clear value in inline datepicker is extremely helpful. So it'd be great to have either "X" button next to calendar icon in date input itself (like in react-datepicker) or "Clear" button in calendar popover itself. |
@sztrzask @RealMarshal dialog actions in the popover is not "material design way" popups must represent 1 action and close. Make "x" adornment to the input similar to keyboard is an option here. But we will not use dialog action with inline pickers |
@dmtrKovalenko Thanks for the answer. Then, if it doesn't contradict Material Design principles, may I create an issue (feature request) to add "x" adornment to the input, that will clear selected date? |
@stsiarzhanau of course that will be nice 👍 |
@dmtrKovalenko you know material design is only recommendations right?
There are some cases where an adornment is not the best option either. A general-purpose-community-component like this should not have these kind of restrictions imo. Modal/full screen date pickers.. never seen. Terrible user experience. |
This PR closes #
Description