Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error with Select drop-down in a modal dialog box #13341

Closed
2 tasks done
gsbelarus opened this issue Oct 22, 2018 · 1 comment
Closed
2 tasks done

Error with Select drop-down in a modal dialog box #13341

gsbelarus opened this issue Oct 22, 2018 · 1 comment
Assignees
@oliviertassinari
Labels
bug 🐛 Something doesn't work component: modal This is the name of the generic UI component, not the React module!

Comments

@gsbelarus
Copy link

gsbelarus commented Oct 22, 2018 •
edited
Loading

You can see this error with a demo code provided on material-ui.com web site.

Just open codepen page with an example:

https://codesandbox.io/s/13zxk7y83q

Then open dialog box, select from first drop down list and try to select from the second list. Then error message appears.

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Both drop down lists should work without errors.

Current Behavior

After selecting from the first drop down list selection from the second will rise an error.

Steps to Reproduce

Link: https://codesandbox.io/s/13zxk7y83q

  1. Load page
  2. Open modal demo dialog box
  3. Select from the first drop down list
  4. Select from the second drop down

Your Environment

Latest Firefox or Chrome.

Tech Version
Material-UI v3.3.0
React 16.5.2
Browser Firefox
TypeScript 3.1.3
etc.
This was referenced Oct 22, 2018
Closed
Closed
@tomijange tomijange mentioned this issue Oct 22, 2018
Merged
1 task
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Oct 22, 2018
@oliviertassinari
Copy link
Member

@gsbelarus Oh wow, we definitely miss a unit test here. Let's fix this regression and add one!

@oliviertassinari oliviertassinari added test component: modal This is the name of the generic UI component, not the React module! labels Oct 22, 2018
@oliviertassinari oliviertassinari self-assigned this Oct 22, 2018
oliviertassinari pushed a commit that referenced this issue Oct 23, 2018
@tomijange @oliviertassinari
[Modal] Fix modalRef is null (#13351)
6ddd5ed 
* fixes #13341

* prettier and lint

* Circle-CI green
@oliviertassinari oliviertassinari mentioned this issue Oct 23, 2018
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliviertassinari oliviertassinari

Labels
bug 🐛 Something doesn't work component: modal This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliviertassinari @gsbelarus