[Modal] Add a failling test case #13350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
universalmind303
commented
Oct 22, 2018
universalmind303
commented
- I have followed (at least) the PR section of the contributing guide.
|
a null check was removed from the codebase, This fixes the Modal onClose error: Cannot read property 'removeAttribute' of null that is now happening on the latest version of Material-UI It looks like it was removed without properly confirming it was safe to remove in this PR |
universalmind303
changed the title
oliviertassinari
added
test
component: modal
oliviertassinari
changed the title
|
@universalmind303 Thank you for taking the time to look into this pull request! @TomiCake has found a nice fix in #13351. I have changed the pull request a bit to contain a failing test case. The failling test case for #13341 and #13349.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.