-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Batch small changes #17807
[core] Batch small changes #17807
Conversation
A slash is usually written without spacing on either side when it connects single words, letters, or symbols.[10] It is, however, common to include a space on each side of the slash when it connects items which themselves have spaces—for example, when marking line breaks in quoted verse or when connecting other items with several words such as "our New Zealand / Western Australia trip".[35] When typesetting a URL or computer path, line breaks should occur before a slash but not in the text between two slashes.[36] https://en.wikipedia.org/wiki/Slash_%28punctuation%29#In_English_text
No bundle size changes comparing 2b9d278...fd01db2 |
Co-Authored-By: Matt <[email protected]>
Co-Authored-By: Josh Wooding <[email protected]>
@@ -68,9 +68,10 @@ Here are the components we will work on being supported in the Material-UI ecosy | |||
| AutoComplete | 🛠 | | |||
| ComboBox | 🛠 | | |||
| MultiSelect | 🛠 | | |||
| Date Picker (& range) | 🛠 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Picker" is pretty heavy jargon and hard to translate. The nav already uses "Date input". We should stick with either one in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fear this question has been sealed for us in the past. People have learned to find this component using the "datepicker" query since jQuery, if not before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Citation needed.
Also: All the more reason to use date input to lure these poor folks using input type="date"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is what I have in mind, we have to match what people query, not improve the searched query: this list contains, I hope, most of the most popular date picker. It's part of the list (I have removed final products) I have used for my proposal in mui/material-ui-pickers#1293 (comment)
- https://baseweb.design/components/datepicker/
- https://material.angular.io/components/datepicker/overview
- http://react.carbondesignsystem.com/?path=/story/datepicker--range-with-calendar
- https://ant.design/components/date-picker/
- https://blueprintjs.com/docs/#datetime/datepicker
- https://bootstrap-datepicker.readthedocs.io/
- https://github.com/airbnb/react-dates
- https://jqueryui.com/datepicker/
- https://material.io/components/pickers/
- https://reactdatepicker.com/
- https://vuetifyjs.com/en/components/date-pickers
- https://www.telerik.com/kendo-react-ui/components/dateinputs/datepicker/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using input type="date"
I think that history has teach us that most of our users don't want to use it 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you include links that don't include pickers and are not translated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is what I have in mind, we have to match what people query,
still looking for a citation here. You reverse this to support your claim when you should provide some evidence what users first think/query vs. how they arrive at a solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do we use "Date input"? I can't find references to it. What's a citation?
Boring changes 😁