Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Batch small changes #17807

Merged
merged 7 commits into from
Oct 10, 2019

Conversation

oliviertassinari
Copy link
Member

Boring changes 😁

A slash is usually written without spacing on either side when it connects single words, letters, or symbols.[10] It is, however, common to include a space on each side of the slash when it connects items which themselves have spaces—for example, when marking line breaks in quoted verse or when connecting other items with several words such as "our New Zealand / Western Australia trip".[35] When typesetting a URL or computer path, line breaks should occur before a slash but not in the text between two slashes.[36]

https://en.wikipedia.org/wiki/Slash_%28punctuation%29#In_English_text
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Oct 9, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 9, 2019

No bundle size changes comparing 2b9d278...fd01db2

Generated by 🚫 dangerJS against fd01db2

@oliviertassinari oliviertassinari merged commit 90cd992 into mui:master Oct 10, 2019
@oliviertassinari oliviertassinari deleted the batch-small-changes-v9 branch October 10, 2019 10:08
@@ -68,9 +68,10 @@ Here are the components we will work on being supported in the Material-UI ecosy
| AutoComplete | 🛠 |
| ComboBox | 🛠 |
| MultiSelect | 🛠 |
| Date Picker (& range) | 🛠 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Picker" is pretty heavy jargon and hard to translate. The nav already uses "Date input". We should stick with either one in the future.

Copy link
Member Author

@oliviertassinari oliviertassinari Oct 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear this question has been sealed for us in the past. People have learned to find this component using the "datepicker" query since jQuery, if not before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Citation needed.

Also: All the more reason to use date input to lure these poor folks using input type="date"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using input type="date"

I think that history has teach us that most of our users don't want to use it 🙃

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you include links that don't include pickers and are not translated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is what I have in mind, we have to match what people query,

still looking for a citation here. You reverse this to support your claim when you should provide some evidence what users first think/query vs. how they arrive at a solution

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we use "Date input"? I can't find references to it. What's a citation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants