Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix 404 links to MUI X API #28176

Merged
merged 4 commits into from
Sep 19, 2021

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 5, 2021

The issue was raised by Moz.com

Screenshot 2021-09-05 at 23 48 11

Try to navigate to the data grid API from the v5 documentation, it fails.

Screenshot 2021-09-06 at 00 02 03

TIL prefetch doesn't work between zones: https://nextjs.org/docs/advanced-features/multi-zones, confirmed in vercel/next.js#4419 (comment).

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Sep 5, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 5, 2021

No bundle size changes

Generated by 🚫 dangerJS against 0afab4f

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the following sort() and map().

Could you go back and check if this worked when the pages were added?

@eps1lon eps1lon changed the base branch from next to master September 14, 2021 09:17
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Sep 17, 2021

This breaks the following sort() and map().

@eps1lon This logic is shallow, it's not applied on the nested array I have modified.

Could you go back and check if this worked when the pages were added?

I had a look at the history. It was broken when introduced. To be more precise. It got done correctly in #26477, targeting the v4 branch. Then I cherry-picked the same changes in the v5 branch, but I didn't account for #23586, so it broke.

docs/src/pages.ts Outdated Show resolved Hide resolved
@eps1lon
Copy link
Member

eps1lon commented Sep 17, 2021

I had a look at the history. It was broken when introduced.

So how was it tested when introduce and how did you test it now?

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Sep 18, 2021

@mnajdova I have changed the approach, this logic will soon be removed once we isolate the different documentation, similarly to how react-aria has its own space https://react-spectrum.adobe.com/react-aria/ vs. https://react-spectrum.adobe.com/react-spectrum/index.html

Screenshot 2021-09-19 at 00 52 24

Soon or later @danilo-leal will figure out a great solution. So, to keep things simple, I have copied and pasted the logic of MUI X. I think that we can call it a day.


So how was it tested when introduce

@eps1lon It was tested on the branch of v4 (master), it wasn't on v5 (next).

how did you test it now

It can be reviewed by opening the Before and After links of the issue's description and making sure the href won't point to a 404

Screenshot 2021-09-19 at 00 50 40

https://mui.com/api/css-baseline/

@oliviertassinari oliviertassinari merged commit c0eaaab into mui:master Sep 19, 2021
@oliviertassinari oliviertassinari deleted the docs-fix-404 branch September 19, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants