-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix 404 links to MUI X API #28176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks the following sort()
and map()
.
Could you go back and check if this worked when the pages were added?
@eps1lon This logic is shallow, it's not applied on the nested array I have modified.
I had a look at the history. It was broken when introduced. To be more precise. It got done correctly in #26477, targeting the v4 branch. Then I cherry-picked the same changes in the v5 branch, but I didn't account for #23586, so it broke. |
So how was it tested when introduce and how did you test it now? |
4d0bfee
to
ac3b236
Compare
@mnajdova I have changed the approach, this logic will soon be removed once we isolate the different documentation, similarly to how react-aria has its own space https://react-spectrum.adobe.com/react-aria/ vs. https://react-spectrum.adobe.com/react-spectrum/index.html Soon or later @danilo-leal will figure out a great solution. So, to keep things simple, I have copied and pasted the logic of MUI X. I think that we can call it a day.
@eps1lon It was tested on the branch of v4 (master), it wasn't on v5 (next).
It can be reviewed by opening the Before and After links of the issue's description and making sure the href won't point to a 404 |
The issue was raised by Moz.com
Try to navigate to the data grid API from the v5 documentation, it fails.
TIL prefetch doesn't work between zones: https://nextjs.org/docs/advanced-features/multi-zones, confirmed in vercel/next.js#4419 (comment).