Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Fix 40x links #28401

Merged
merged 1 commit into from
Sep 17, 2021
Merged

[website] Fix 40x links #28401

merged 1 commit into from
Sep 17, 2021

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Sep 17, 2021

Fixing some dead links reported by moz.com


The ones left are related to the API pages of the DataGrid. Looks like the URLs for the API pages changed. The SideBar references URLs starting with /api-docs/data-grid/*, but the valid links are actually starting with /api/data-grid/*. We should either change the _redirecs:

diff --git a/docs/public/_redirects b/docs/public/_redirects
index 9678655950..65243167a0 100644
--- a/docs/public/_redirects
+++ b/docs/public/_redirects
@@ -184,7 +184,7 @@ https://v4.material-ui.com/* https://v4.mui.com/:splat 301!
 ## material-ui-x
 ## Unlike the store that expect to be hosted under a subfolder,
 ## material-ui-x is configured to be hosted at the root.
-/api/*/ https://docs-v5--material-ui-x.netlify.app/api/:splat/ 200
+/api-docs/*/ https://docs-v5--material-ui-x.netlify.app/api/:splat/ 200
 /:lang/api/*/ https://docs-v5--material-ui-x.netlify.app/:lang/api/:splat/ 200
 /components/* https://docs-v5--material-ui-x.netlify.app/components/:splat 200
 /:lang/components/* https://docs-v5--material-ui-x.netlify.app/:lang/components/:splat 200

Or fix the links in the Sidebar. Probably @m4theushw can give us more details.

Edit: this is being handled in #28176

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 17, 2021

No bundle size changes

Generated by 🚫 dangerJS against 097ba91

@mnajdova mnajdova merged commit 0035aaf into mui:master Sep 17, 2021
@zannager zannager added the website Pages that are not documentation-related, marketing-focused. label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants