-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Remove languages: fr, de, ja, es, ru #28663
Conversation
@mbrookes what should be changed on https://translate.mui.com? |
We should flip https://github.com/mui-org/material-ui/blob/5c68fe51b3369a746e82c1594046bc69f3821dd9/docs/next.config.js#L211-L211 to build all locales for testing purposes before merging. |
I think that we should update https://github.com/mui-org/material-ui-com/blob/master/_redirects to redirect the old URLs. For instance https://material-ui.com/fr/components/alert/ should be a 301 to https://mui.com/components/alert/. |
docs/public/_redirects
Outdated
@@ -177,6 +177,8 @@ https://v4.material-ui.com/* https://v4.mui.com/:splat 301! | |||
/fr/* /:splat 200 | |||
/de/* /:splat 200 | |||
/ja/* /:splat 200 | |||
/ru/* /:splat 200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also added redirects for the languages that are removed
These are not redirections, they are proxies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I haven't noticed the HTTP status code. Were these previously added for the new pages only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should we actually make these redirects if we no longer want to support these languages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fr
, de
, ja
were not server-side rendered (next.js exportPathMap function), so we had to proxied them. In our case, we can turn them all to a 301. No need for the !
as the HTML files won't exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaaah ok, it makes sense now, wasn't sure why these three were only added. Thanks for the clarification. Will update them now
Created https://github.com/mui-org/material-ui-com/pull/1 |
I'll remove the languages that have been removed here. Frankly though, unless Crowdin step up, and fix the issues that prevent further translation of Chinese and Portuguese Brazilian, we might as well give up on translation altogether. It would be a terrible waste, given the time, effort and money that's gone into building the i18n infrastructure, and translations, but half translated is worse than untranslated. |
It looks good. The next SEO crawl will ultimately confirm if it's a step forward 😁. I recall spending 4 weekends in a row in 2019 to fix everything. At each iteration, I would miss something. |
@mbrookes Would it make sense to give them an ultimatum? I'm curious to see how React will handle this problem with https://github.com/reactjs/reactjs.org-translation. Did they say that they are working on a rewrite of the docs? |
A little hard to do when we use their services for free (even though we acknowledge them in the README). I've sent another follow-up to the case I opened in January. After that, I guess we look for an alternative, or give up on handling the docs i18n natively, and leave l10n to 3rd-party forks. (Yes, React are doing a functional component/hooks based rewrite.)
This is done BTW, along with removing v4 I took a local copy of the translations, in case we decide to reinstate any of them in the future. |
The PR removes the following languages from the docs - fr, de, ja, es, ru. The community has not been able to translate them enough. They are up to date, but in English, so not really helpful. They are also the ones with the less usage.
I recommend review per commit.
I've also added redirects for the languages that are removed, let me know if I should revert this change.
TODO: