Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove languages: fr, de, ja, es, ru #28663

Merged
merged 6 commits into from
Sep 29, 2021
Merged

[docs] Remove languages: fr, de, ja, es, ru #28663

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0635cc0
[docs] Remove translation files for fr, de, ja, es, ru
mnajdova Sep 28, 2021
f9d2272
[docs] Remove languages from constants
mnajdova Sep 28, 2021
96634bd
[docs] Add redirects for the removed languages
mnajdova Sep 28, 2021
bdad428
Test building of locales
mnajdova Sep 28, 2021
a8eaa5a
update localizations to be redirects
mnajdova Sep 28, 2021
d894452
Revert next.config.js
mnajdova Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/public/_redirects
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,8 @@ https://v4.material-ui.com/* https://v4.mui.com/:splat 301!
/fr/* /:splat 200
/de/* /:splat 200
/ja/* /:splat 200
/ru/* /:splat 200
Copy link
Member

@oliviertassinari oliviertassinari Sep 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also added redirects for the languages that are removed

These are not redirections, they are proxies.

Copy link
Member Author

@mnajdova mnajdova Sep 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I haven't noticed the HTTP status code. Were these previously added for the new pages only?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should we actually make these redirects if we no longer want to support these languages?

Copy link
Member

@oliviertassinari oliviertassinari Sep 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fr, de, ja were not server-side rendered (next.js exportPathMap function), so we had to proxied them. In our case, we can turn them all to a 301. No need for the ! as the HTML files won't exist.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaaah ok, it makes sense now, wasn't sure why these three were only added. Thanks for the clarification. Will update them now

/es/* /:splat 200

## Store
/store/* https://material-ui-store.netlify.app/:splat 200
Expand Down