[Joy] Add default color to Input and ListItemButton
#31826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mui/joy: parsed: +2.20% , gzip: +0.79% |
hbjORbj
reviewed
Mar 16, 2022
| outlinedHoverBg: 'var(--joy-palette-neutral-outlinedHoverBg)', | ||
| outlinedHoverBorder: 'var(--joy-palette-neutral-outlinedHoverBorder)', | ||
| outlinedActiveBg: 'var(--joy-palette-neutral-outlinedActiveBg)', | ||
| outlinedDisabledColor: 'var(--joy-palette-neutral-outlinedDisabledColor)', | ||
| outlinedDisabledBorder: 'var(--joy-palette-neutral-outlinedDisabledBorder)', | ||
| lightColor: 'var(--joy-palette-neutral-lightColor)', | ||
| lightBg: 'var(--joy-palette-neutral-lightBg)', | ||
| lightHoverColor: 'var(--joy-palette-neutral-lightHoverColor)', |
There was a problem hiding this comment.
Are we intentionally not having containedHoverColor?
There was a problem hiding this comment.
I think @danilo-leal will tweak the colors again.
hbjORbj
reviewed
Mar 16, 2022
| @@ -143,7 +143,7 @@ const Avatar = React.forwardRef(function Avatar(inProps, ref) { | |||
| color = 'neutral', | |||
| component = 'div', | |||
| size = 'md', | |||
| variant = 'contained', | |||
| variant = 'light', | |||
There was a problem hiding this comment.
One intention of the global variant is to bring attention. Currently contained brings the most attention and text be the last. My feeling is that Avatar is a complimentary UI, so it should not be contained by default.
hbjORbj
reviewed
Mar 16, 2022
| sx?: SxProps; | ||
| }; | ||
| props: P & | ||
| SystemProps & { |
There was a problem hiding this comment.
😂 I missed this type in the Typography PR.
hbjORbj
approved these changes
Mar 16, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The current implementation allows some components to have a variant without a color. However, for Input & ListItemButton, they are interactive which need colors on hover, active, disabled. At initial state, they use
text.primarycolor and use theneutralcolor for other states if the color prop isundefined. I think it creates confusion for customization and developers will have to remember about these specific components.I think it would be better to just use neutral color directly and does not allow any components to have a variant without a color (for the default case).
Changes
neutralvariant tokens to have higher contrastInput&ListItemButtonto haveneutralcolor by default<Typography color="primary.textColor" fontWeight="sm">