Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Joy] Add tests for Avatar component #31829

Merged
merged 2 commits into from
Mar 16, 2022
Merged

[Joy] Add tests for Avatar component #31829

merged 2 commits into from
Mar 16, 2022

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented Mar 16, 2022

@hbjORbj hbjORbj added test component: avatar This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Mar 16, 2022
@hbjORbj hbjORbj requested a review from siriwatknp March 16, 2022 09:30
@mui-bot
Copy link

mui-bot commented Mar 16, 2022

No bundle size changes

Generated by 🚫 dangerJS against 884d304

it('contained by default', () => {
const { getByTestId } = render(<Avatar data-testid="root" />);

expect(getByTestId('root')).to.have.class(classes.variantContained);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
expect(getByTestId('root')).to.have.class(classes.variantContained);
expect(getByTestId('root')).to.have.class(classes.variantLight);

You might have to update this one because of #31826.

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nicely done!

@hbjORbj hbjORbj merged commit 1b7d31e into mui:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: avatar This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants