Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField] Fix floating label position #36246

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Feb 18, 2023

I never thought that there would still be bugs opportunities in this outline input 😁. You can reproduce this on https://codesandbox.io/s/muddy-leaf-t4y7z5?file=/package.json

import * as React from "react";
import Box from "@mui/material/Box";
import TextField from "@mui/material/TextField";

export default function BasicTextFields() {
  return (
    <Box sx={{ m: 2 }}>
      <TextField
        id="outlined-basic"
        InputLabelProps={{ shrink: true }}
        label="Foo Foo Foo Foo Foo Foo Foo F"
        variant="outlined"
      />
    </Box>
  );
}

Before:

Screenshot 2023-02-19 at 00 55 10

After:

Screenshot 2023-02-19 at 01 02 16


I have noticed this on https://next.mui.com/x/react-date-pickers/getting-started/#installation, it feels broken:

Screenshot 2023-02-19 at 00 57 29

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work design: material This is about Material Design, please involve a visual or UX designer in the process component: text field This is the name of the generic UI component, not the React module! labels Feb 18, 2023
@mui-bot
Copy link

mui-bot commented Feb 18, 2023

Netlify deploy preview

https://deploy-preview-36246--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 2e13f8b

@oliviertassinari oliviertassinari added the design This is about UI or UX design, please involve a designer label Feb 19, 2023
@zannager zannager requested a review from michaldudak February 20, 2023 11:33
@oliviertassinari oliviertassinari requested review from mj12albert and removed request for michaldudak February 21, 2023 21:40
@oliviertassinari oliviertassinari changed the title [TextField] Fix floating label positon [TextField] Fix floating label position Feb 22, 2023
@oliviertassinari oliviertassinari added package: material-ui Specific to @mui/material and removed design: material This is about Material Design, please involve a visual or UX designer in the process labels Feb 22, 2023
@mnajdova mnajdova merged commit 1dfc14f into mui:master Feb 27, 2023
@oliviertassinari oliviertassinari deleted the textfield-fix-outlined branch February 27, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants