Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][joy] Build TS versions for Textarea component demos #36371

Merged
merged 4 commits into from
Feb 28, 2023
Merged

[docs][joy] Build TS versions for Textarea component demos #36371

merged 4 commits into from
Feb 28, 2023

Conversation

varunmulay22
Copy link
Contributor

@varunmulay22 varunmulay22 commented Feb 28, 2023 •
edited
Loading

Part of #36367

@mui-bot
Copy link

mui-bot commented Feb 28, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-36371--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 9aef8d7

@varunmulay22 varunmulay22 mentioned this pull request Feb 28, 2023
Closed
10 tasks
@hbjORbj hbjORbj requested a review from a team February 28, 2023 13:45
@hbjORbj hbjORbj changed the title Textarea component tsx demos created [docs][joy] Build TS versions for Textarea component demos Feb 28, 2023
@hbjORbj hbjORbj added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy labels Feb 28, 2023
hbjORbj
hbjORbj reviewed Feb 28, 2023
View reviewed changes
Copy link
Member

@hbjORbj hbjORbj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I see you've changed label to name in all demos. What is the motivation behind this?

@varunmulay22
Copy link
Contributor Author

varunmulay22 commented Feb 28, 2023 •
edited
Loading

Thanks for the PR. I see you've changed label to name in all demos. What is the motivation behind this?

It's weird you don't get a TS error with label. Its not exposed as an acceptable attribute in TextareaProps.ts. Hence I changed it to name

@varunmulay22 varunmulay22 reopened this Feb 28, 2023
@varunmulay22 varunmulay22 requested a review from hbjORbj February 28, 2023 14:00
@hbjORbj
Copy link
Member

hbjORbj commented Feb 28, 2023

It's a HTML attribute, so we can revert it back to label.

@varunmulay22
Copy link
Contributor Author

varunmulay22 commented Feb 28, 2023 •
edited
Loading

It's a HTML attribute, so we can revert it back to label.

This test_types check might help you understand better why I implemented name before. We either need to include label in the acceptable attributes in TextareaProps.ts, remove the labels from all tsx demos or replace label with one of the available attributes. IMHO. Apologies my explanation wasn't as clear before

@hbjORbj
Copy link
Member

hbjORbj commented Feb 28, 2023

Ah, I see it now. Yes, in that case, I agree with name. :)

@varunmulay22
Copy link
Contributor Author

All tests passing.....lezzzz goooooooo 🎸

hbjORbj
hbjORbj approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant!

@hbjORbj hbjORbj merged commit 835e53e into mui:master Feb 28, 2023
@varunmulay22
Copy link
Contributor Author

Ill get onto the other components 🕺🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbjORbj hbjORbj hbjORbj approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varunmulay22 @mui-bot @hbjORbj