-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build TypeScript demos for all Joy components #36367
Comments
@hbjORbj may I kindly pick this up? Thanks |
@varunmulay22 Would you take a component and create a PR for that :) ? If you finish with that component, then you can create another one. As explained in the description above, after creating a PR, please paste the URL next to the component and check the box in the description. |
Sure this works for me thanks a ton |
@hbjORbj I did push changes for the TextArea component here but I'm unable to tag @mui/core. Are you sure this is the tag we should be using thanks again Edit: Looks like an access issue for me. I cannot edit your comment from above also. Can you help please :) |
That's odd. I am not sure about that. Maybe because you are a first-time contributor? I requested a review from the core team on your behalf and added your PR URL as well. |
that's awesome Benny! much appreciated 😄 |
Hmm, okay. I reviewed it for now. Thanks. |
@hbjORbj still unable to tag or edit your comment from above. You may expect a few more PR's till EOI 😅 |
@varunmulay22 before working on component, can you mention here, which component you started working on so that others can pick another component |
@sai6855 You do the same too please. I am picking up switch radio, modal and menu next |
@varunmulay22 okay, I'll pick checkbox,list, select |
Thanks, both of you! Don't worry, once you create a PR, I will paste the URL. |
@varunmulay22 Are you working on Radio as well? |
@varunmulay22 if you are not working on radio, i can pick it up |
Thanks a lot, I'll start radio once list is done |
Hi , yeah I mentioned same in this comment #36367 (comment). You probably might have missed it, Maybe you can work on this issue #35933? |
Yeah I’m sorry I missed it, thank for that recommendation! |
You need not be worried about labels, only maintainers can add labels. Once they add labels ci check will pass |
Reviewed and approved your PR for the Radio. Thanks! @sai6855 |
@hbjORbj 3 PR's are ready for review |
This is now complete! Thanks for the contributions <3 |
We need your help!
Some Joy components do not have TypeScript versions of demos but only JavaScript demos. We need the community's help to ensure that all Joy components have TypeScript demos.
Contribution guides
docs/data/joy/components/${component}
directory..tsx
) versions, create typescript files with the same name. For example,docs/data/joy/components/Checkbox
hasCheckboxColors.js
while it doesn't haveCheckboxColors.tsx
. CreateCheckboxColors.tsx
.Warning⚠️ : For
${Component}Variables.js
and${Component}Usage.js
, we DO NOT need typescript versions.yarn docs:typescript:formatted
andyarn prettier
.yarn docs:dev
./joy-ui/react-{component}/
(e.g.,/joy-ui/react-checkbox
) and check the demos (it should look the same).Example PR
#36366
List of components
Ready to be picked up
Divider
#36374The text was updated successfully, but these errors were encountered: