Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blog] Discord announcement blog #38258

Merged
merged 32 commits into from
Aug 4, 2023
Merged

[blog] Discord announcement blog #38258

merged 32 commits into from
Aug 4, 2023

Conversation

richbustos
Copy link
Contributor

@richbustos richbustos commented Aug 1, 2023

Quick and simple blog to let everyone know we are on Discord!

https://deploy-preview-38258--material-ui.netlify.app/blog/discord-announcement/

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me! 🤙

@mui-bot
Copy link

mui-bot commented Aug 1, 2023

Netlify deploy preview

https://deploy-preview-38258--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 23b0d41

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • A dead file docs/public/static/blog/2023-discord-announcement/discord-preview.png?
  • It's close to 1 MB docs/public/static/blog/2023-discord-announcement/discord.png is there room to compress it?

docs/pages/blog/2023-discord-announcement.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-discord-announcement.md Outdated Show resolved Hide resolved
@richbustos
Copy link
Contributor Author

richbustos commented Aug 2, 2023

  • A dead file docs/public/static/blog/2023-discord-announcement/discord-preview.png?
  • It's close to 1 MB docs/public/static/blog/2023-discord-announcement/discord.png is there room to compress it?
  • yup, dead file. Was going to post a screenshot of the server but it didnt add any value when writing about it. I removed it
  • I ran it through image optim before uploading. Will see if i can compress it more
    Edit: I got it down to 556kb. will that suffice?

For future reference, whats our goal for image sizes in blogs?

Screen Shot 2023-08-02 at 11 58 34 AM

Copy link
Contributor

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better in the latest draft!

Let's drop 2023- from the file names—no need for it.

docs/pages/blog/2023-discord-announcement.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-discord-announcement.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-discord-announcement.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-discord-announcement.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-discord-announcement.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-discord-announcement.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-discord-announcement.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-discord-announcement.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-discord-announcement.md Outdated Show resolved Hide resolved
docs/pages/blog/2023-discord-announcement.md Outdated Show resolved Hide resolved
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great 👍

docs/pages/blog/discord-announcement.md Outdated Show resolved Hide resolved
richbustos and others added 18 commits August 4, 2023 06:59
Co-authored-by: Sam Sycamore <[email protected]>
Signed-off-by: Rich Bustos <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Signed-off-by: Rich Bustos <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Signed-off-by: Rich Bustos <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Signed-off-by: Rich Bustos <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Signed-off-by: Rich Bustos <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Signed-off-by: Rich Bustos <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Signed-off-by: Rich Bustos <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Signed-off-by: Rich Bustos <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Signed-off-by: Rich Bustos <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Signed-off-by: Rich Bustos <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Signed-off-by: Rich Bustos <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Signed-off-by: Rich Bustos <[email protected]>
@richbustos richbustos merged commit eeb0805 into master Aug 4, 2023
@richbustos richbustos deleted the blog-discord branch August 4, 2023 14:54
richbustos added a commit that referenced this pull request Aug 4, 2023
Signed-off-by: Rich Bustos <[email protected]>
Co-authored-by: Rich Bustos <[email protected]>
Co-authored-by: Danilo Leal <[email protected]>
Co-authored-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Olivier Tassinari <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
richbustos added a commit that referenced this pull request Aug 7, 2023
Signed-off-by: Rich Bustos <[email protected]>
Co-authored-by: Rich Bustos <[email protected]>
Co-authored-by: Danilo Leal <[email protected]>
Co-authored-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Olivier Tassinari <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
oliviertassinari added a commit to oliviertassinari/material-ui that referenced this pull request Sep 6, 2023
See how https://twitter.com/MUI_hq/status/1688919247504957440 doesn't have a card.
It's a follow-up on mui#38258.

I think that we should be able to fail the build if the card is missing, but too lazy.
oliviertassinari added a commit to oliviertassinari/material-ui that referenced this pull request Sep 6, 2023
See how https://twitter.com/MUI_hq/status/1688919247504957440 doesn't have a card.
It's a follow-up on mui#38258.

I think that we should be able to fail the build if the card is missing, but too lazy.
oliviertassinari added a commit to oliviertassinari/material-ui that referenced this pull request Sep 6, 2023
See how https://twitter.com/MUI_hq/status/1688919247504957440 doesn't have a card.
It's a follow-up on mui#38258.

I think that we should be able to fail the build if the card is missing, but too lazy.
oliviertassinari added a commit to oliviertassinari/material-ui that referenced this pull request Sep 6, 2023
See how https://twitter.com/MUI_hq/status/1688919247504957440 doesn't have a card.
It's a follow-up on mui#38258.

I think that we should be able to fail the build if the card is missing, but too lazy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants