Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][base] Add Tailwind CSS + plain CSS demo on the Select page #38367

Merged
merged 4 commits into from
Aug 15, 2023
Merged

[docs][base] Add Tailwind CSS + plain CSS demo on the Select page #38367

merged 4 commits into from
Aug 15, 2023

Conversation

alisasanib
Copy link
Contributor

Part of #37222

@mui-bot
Copy link

mui-bot commented Aug 7, 2023 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 37e1850

@zannager zannager added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Aug 8, 2023
@zannager zannager requested a review from mnajdova August 8, 2023 09:12
mnajdova
mnajdova reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestions for code changes so that we are prepared for #38464

docs/data/base/components/select/UnstyledSelectIntroduction/tailwind/index.tsx Outdated Show resolved Hide resolved
docs/data/base/components/select/UnstyledSelectIntroduction/tailwind/index.tsx Outdated Show resolved Hide resolved
@alisasanib alisasanib marked this pull request as draft August 14, 2023 18:19
@mnajdova mnajdova marked this pull request as ready for review August 15, 2023 10:38
mnajdova
mnajdova approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed few fixes, looks good to me now. Thanks for the contribution!

@mnajdova mnajdova merged commit 39d11b4 into mui:master Aug 15, 2023
@alisasanib alisasanib mentioned this pull request Aug 15, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees

@zanivan zanivan

Labels
docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alisasanib @mui-bot @mnajdova @zanivan @zannager