Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] Remove Alt+C keyboard shortcut #5618

Closed
Tracked by #3287
joserodolfofreitas opened this issue Jul 26, 2022 · 1 comment · Fixed by #7466
Closed
Tracked by #3287

[data grid] Remove Alt+C keyboard shortcut #5618

joserodolfofreitas opened this issue Jul 26, 2022 · 1 comment · Fixed by #7466
Assignees
@MBilalShafi
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer feature: Selection Related to the data grid Selection feature v6.x

Comments

@joserodolfofreitas
Copy link
Member

Summary

Remove Alt+C keyboard shortcut. It copies selected rows including headers.

Motivation

It's not intuitive and using Option for shortcut on MacOS is tricky (#3658). Instead, we might want to add a prop clipboardCopyIncludeHeaders or allow users to register their own shortcuts using apiRef.

Challenge

how do we teach non-standard shortcuts to end-users?
@joserodolfofreitas joserodolfofreitas added breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x feature: Selection Related to the data grid Selection feature design: ux labels Jul 26, 2022
@joserodolfofreitas joserodolfofreitas mentioned this issue Jul 26, 2022
Closed
41 tasks
@joserodolfofreitas
Copy link
Member Author

We can remove the shortcut as a first step. We'll re-evaluate the approach as a part (or followup) of #7389.

@joserodolfofreitas joserodolfofreitas removed their assignment Jan 10, 2023
@MBilalShafi MBilalShafi mentioned this issue Jan 10, 2023
Merged
cherniavskii pushed a commit that referenced this issue Jan 13, 2023
@MBilalShafi
[DataGrid] Remove Alt+C keyboard shortcut (#7466)
58b2df2 
Closes #5618
@cherniavskii cherniavskii mentioned this issue May 8, 2023
Merged
15 tasks
@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer and removed design: ux labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MBilalShafi MBilalShafi

Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer feature: Selection Related to the data grid Selection feature v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Remove Alt+C keyboard shortcut MBilalShafi/mui-x
3 participants
@joserodolfofreitas @oliviertassinari @MBilalShafi