Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Remove Alt+C keyboard shortcut #7466

Merged
merged 2 commits into from
Jan 13, 2023
Merged

[DataGrid] Remove Alt+C keyboard shortcut #7466

merged 2 commits into from
Jan 13, 2023

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Jan 10, 2023 •
edited
Loading

Relates to #3287
Closes #5618

Changelog

Breaking changes

  • Alt(or ⌥ Option) + C keyboard shortcut is no longer supported

@MBilalShafi MBilalShafi self-assigned this Jan 10, 2023
@mui-bot
Copy link

mui-bot commented Jan 10, 2023 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-7466--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 623.5 927.1 758.5 764.38 119.272
Sort 100k rows ms 637.6 1,197.3 701.8 875.98 198.643
Select 100k rows ms 195.4 303.4 256.3 248.22 41.309
Deselect 100k rows ms 140.7 282.9 186 191.16 51.465

Generated by 🚫 dangerJS against 7aa45f2

@MBilalShafi MBilalShafi changed the title [DataGrid] Remove Alt+C keyboard shortcut [DataGrid] Remove <kbd>Alt</kbd>+<kbd>C</kbd> keyboard shortcut Jan 11, 2023
@MBilalShafi MBilalShafi changed the title [DataGrid] Remove <kbd>Alt</kbd>+<kbd>C</kbd> keyboard shortcut [DataGrid] Remove Alt+C keyboard shortcut Jan 11, 2023
m4theushw
m4theushw approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MBilalShafi MBilalShafi added the component: data grid This is the name of the generic UI component, not the React module! label Jan 13, 2023
@cherniavskii cherniavskii merged commit 58b2df2 into mui:next Jan 13, 2023
@MBilalShafi MBilalShafi deleted the remove-alt-c branch January 13, 2023 13:35
@MBilalShafi MBilalShafi mentioned this pull request Jan 13, 2023
Merged
@oliviertassinari oliviertassinari mentioned this pull request Jun 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw approved these changes

@joserodolfofreitas joserodolfofreitas joserodolfofreitas approved these changes

Assignees

@MBilalShafi MBilalShafi

Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Remove Alt+C keyboard shortcut
5 participants
@MBilalShafi @mui-bot @joserodolfofreitas @m4theushw @cherniavskii