Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Remove Header component slot #6977

Closed
2 tasks done
Tracked by #3287
cherniavskii opened this issue Nov 23, 2022 · 1 comment · Fixed by #6999
Closed
2 tasks done
Tracked by #3287

[DataGrid] Remove Header component slot #6977

cherniavskii opened this issue Nov 23, 2022 · 1 comment · Fixed by #6999
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x

Comments

@cherniavskii
Copy link
Member

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

We advise using the Toolbar slot instead:

mui-x/packages/grid/x-data-grid/src/models/gridSlotsComponent.ts

Lines 79 to 84 in 4891eaf

/**
* Header component rendered above the grid column header bar.
* Prefer using the `Toolbar` slot. You should never need to use this slot.
* @default GridHeader
*/
Header: React.JSXElementConstructor<any>; // TODO remove.

Removing this slot also solves the confusion raised in #597 (review)

Examples 🌈

No response

Motivation 🔦

No response

Order ID 💳 (optional)

No response
@cherniavskii cherniavskii added breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x labels Nov 23, 2022
This was referenced Nov 23, 2022
Closed
Closed
@oliviertassinari
Copy link
Member

This sounds great. I never understood why this slot existed. The developers that customize the header slot lose the PreferencesPanel.

@cherniavskii cherniavskii mentioned this issue Nov 25, 2022
Merged
cherniavskii added a commit that referenced this issue Dec 2, 2022
@cherniavskii
[DataGrid] Remove Header slot (#6999)
626106b 
Closes #6977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Remove Header slot cherniavskii/mui-x
2 participants
@oliviertassinari @cherniavskii