Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Remove Header slot #6999

Merged
merged 2 commits into from
Dec 2, 2022
Merged

[DataGrid] Remove Header slot #6999

merged 2 commits into from
Dec 2, 2022

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Nov 25, 2022 •
edited
Loading

Closes #6977

Breaking changes

  • The components.Header slot was removed. Use components.Toolbar slot instead.

@cherniavskii cherniavskii added breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x labels Nov 25, 2022
@mui-bot
Copy link

mui-bot commented Nov 25, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6999--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 645.4 1,836.6 645.4 1,011.04 438.285
Sort 100k rows ms 568 1,437.7 568 989.56 296.905
Select 100k rows ms 213 319.6 267.9 259.42 38.303
Deselect 100k rows ms 156.1 251.1 187.5 204.66 38.807

Generated by 🚫 dangerJS against 0abb55b

@cherniavskii cherniavskii marked this pull request as ready for review December 2, 2022 10:40
@cherniavskii cherniavskii enabled auto-merge (squash) December 2, 2022 10:42
@cherniavskii cherniavskii merged commit 626106b into mui:next Dec 2, 2022
@cherniavskii cherniavskii deleted the remove-header-slot branch December 2, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanailH DanailH DanailH approved these changes

@m4theushw m4theushw Awaiting requested review from m4theushw

Assignees
No one assigned
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DataGrid] Remove Header component slot
3 participants
@cherniavskii @mui-bot @DanailH